[HOLD for payment 2024-08-02] [$250] Android - chat - After sending emoji art, tapping emoji picker app crashes

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4727506
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Tap on a report
3. From the link - https://www.copyandpasteemojiart.com/?m=1

• copy the below image

4. Paste the image
5. Send the message
6. Tap emoji picker

Expected Result:

After sending emoji art, tapping emoji picker app must not crash

Actual Result:

After sending emoji art, tapping emoji picker app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6544125_1721145317636.em.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01742f04a35f007ec9
• Upwork Job ID: 1814237444519918825
• Last Price Increase: 2024-07-19
• Automatic offers:
• suneox | Reviewer | 103213907

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[layacat]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - chat - After sending emoji art, tapping emoji picker app crashes

What is the root cause of that problem?

We recently added frequentlyUsedEmojis that loaded from Onyx (ONYXKEYS.FREQUENTLY_USED_EMOJIS).
However the emoji code from Onyx is different with the data we have in our common file

App/src/libs/EmojiUtils.ts

Lines 43 to 46 in 52b8fdd

	const emojiWithSkinTones = Emojis.emojiCodeTableWithSkinTones[emoji.code];
	return {...emojiWithSkinTones, count: item.count, lastUpdatedAt: item.lastUpdatedAt};
	})
	.filter((emoji): emoji is FrequentlyUsedEmoji => !!emoji) ?? [];

That will make emojiWithSkinTones above return undefined, frequentlyUsedEmojis will have item that don't have code or name.
Later when we use it in addSpacesToEmojiCategories function it will crash which is the RCA.

What changes do you think we should make in order to solve the problem?

Update the emoji in our common.ts that matches the data from Onyx.

☁️ to ☁
Here's the diff:

What alternative solutions did you explore? (Optional)

Filter all the falsely emoji (don't have both name and code) in here

Result:

Screen.Recording.2024-07-17.at.13.58.06.mov

[zanyrenney]

adding external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01742f04a35f007ec9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)