[HOLD for payment 2024-08-02] [$250] Workspace - "Remove member" modal show that the user is an approver when they are not approver

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace
3. Go to workspace settings > Members
4. Add some members
5. Click on any member
6. Click Remove from workspace

Expected Result:

"Remove member" modal will not show that the user is an approver if they are not an approver

Actual Result:

"Remove member" modal show that the user is an approver when they are not an approver

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6543977_1721137169629.20240716_213707.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b2f905d2ab7918d6
• Upwork Job ID: 1813404779499632184
• Last Price Increase: 2024-07-17
• Automatic offers:
• allgandalf | Reviewer | 103193071

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Remove member" modal show that the user is an approver when they are not approver

What is the root cause of that problem?

When isApprover is false, we are not returning translate('workspace.people.removeMemberPrompt', {memberName: displayName});. Therefore, code execution continues to the next line of code and return translate('workspace.people.removeMembersWarningPrompt', {memberName: displayName, ownerName: policyOwnerDisplayName});

App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Lines 73 to 77 in e009c43

	if (!isApprover) {
	translate('workspace.people.removeMemberPrompt', {memberName: displayName});
	}
	return translate('workspace.people.removeMembersWarningPrompt', {memberName: displayName, ownerName: policyOwnerDisplayName});
	}, [accountID, policy, displayName, policyOwnerDisplayName, translate]);

What changes do you think we should make in order to solve the problem?

Add return statement before translate('workspace.people.removeMemberPrompt', {memberName: displayName});

return translate('workspace.people.removeMemberPrompt', {memberName: displayName});

Note: isApprover seems to be returning false for approver too. We can fix that too by adding || employeeLogin === policy?.approver below (LN 108)

App/src/libs/actions/Policy/Member.ts

Lines 105 to 108 in 307565a

	function isApprover(policy: OnyxEntry<Policy>, employeeAccountID: number) {
	const employeeLogin = allPersonalDetails?.[employeeAccountID]?.login;
	return Object.values(policy?.employeeList ?? {}).some(
	(employee) => employee?.submitsTo === employeeLogin || employee?.forwardsTo === employeeLogin || employee?.overLimitForwardsTo === employeeLogin,

Doing that will fix similar issues on workspace member page too

What alternative solutions did you explore? (Optional)

Result:

Screen.Recording.2024-07-16.at.10.26.11.at.night.mp4

[etCoderDysto]

Proposal Updated:

• Added result

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b2f905d2ab7918d6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[codeapexdev]

Proposal

Problem Statement
"Remove member" modal should show that the user is an approver when they are not an approver but it is showing user is an approver even if they are not an approver.

Problem
In the confirm modal prompt, we are getting the false value in isApprover but it is not returned

Solution
return translate('workspace.people.removeMemberPrompt', {memberName: displayName});

Contributor details
Your Expensify account email: akashftg@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0114eee6cee79fee8e