[HOLD for payment 2024-08-27] [$250] Clicking on new message doesn't navigate to the last message for 2nd comment link

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.5-2
Reproducible in staging?: y
Reproducible in production?: y
Issue found when executing PR: #41962
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Start a chat with account B as account A
3. Send 200 messages (Or use this expensifail account applausetester+nlinbx@applause.expensifail.com
   )
4. Copy the link of the 70th comment and send it
5. Copy the link of the 150th comment and send it
6. Go to troubleshoot and clear cache and restart
7. Click on the first link sent on step 4
8. Click on the "New message" badge that appeared at the top of the chat
9. Confirm the page scrolls to the bottom of the comment history
10. Click on the second link sent on step 5.
11. Click on the "New message" badge once again

Expected Result:

The report page scrolls down to the bottom of the comment history

Actual Result:

The report page doesn't scroll down to the bottom of the comment history after clicking on the second link, and this time clicking on the first link and then clicking on the new message badge no longer scrolls to the bottom of the comment history as well.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6535893_1720445935785.bandicam_2024-07-08_16-28-48-145.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0188f7ddb71ba94170
• Upwork Job ID: 1810560415299355486
• Last Price Increase: 2024-07-23
• Automatic offers:
• tsa321 | Contributor | 103330551

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kbecciv]

@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[RachCHopkins]

Replicated - To be fair my "new message" button didn't take me to the recent message at any point.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0188f7ddb71ba94170

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on a new message doesn't navigate to the last message for 2nd comment link

What is the root cause of that problem?

We navigate to the report route instead of scrolling to bottom if hasNewestReportAction is false

App/src/pages/home/report/ReportActionsList.tsx

Lines 407 to 412 in dd96852

	const scrollToBottomAndMarkReportAsRead = () => {
	if (!hasNewestReportAction) {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
	Report.openReport(report.reportID);
	return;
	}

What changes do you think we should make in order to solve the problem?

Scroll to the bottom instead if hasNewestReportAction is false

        if (!hasNewestReportAction) {
            reportScrollManager.scrollToBottom();
        }

RESULT

New-Expensify.7.mp4

What alternative solutions did you explore? (Optional)

Remove the If clause

    const scrollToBottomAndMarkReportAsRead = () => {
        reportScrollManager.scrollToBottom();
        readActionSkipped.current = false;
        Report.readNewestAction(report.reportID);
    };

[nyomanjyotisa]

Proposal updated