[HOLD for payment 2024-07-17] Track expense - "Hold" option should not appear for tracked expense in combined report

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0-3.2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com/
2. Go to workspace chat that has no unsettled expense
3. Go to + > Track expense
4. Track a manual expense
5. Go to transaction thread (combined report)
6. Click 3-dot menu
7. Note that Hold option is available for tracked expense in the combined report
8. Submit another expense
9. Go to transaction thread of the tracked expense in Step 4
10. Click 3-dot menu
11. Note that Hold option is actually not available for tracked expense (this is the correct behavior)

Expected Result:

In Step 7, in one-report combined view, "Hold" option should not show up for the tracked expense

Actual Result:

In Step 7, in one-report combined view, "Hold" option shows up for the tracked expense in 3-dot menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6527316_1719574473097.20240628_192942.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@NikkiWines FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[NikkiWines]

This is almost certainly from #43618. I don't think this should be a blocker even if the behavior isn't what we intend though, it's fairly low impact and doesn't come across as "buggy".

@trjExpensify just to confirm, do you think we should show the HOLD option for Track expenses? If not, let's open a new issue to rectify this rather than reverting the whole PR.

[trjExpensify]

@NikkiWines I don't think you should be able to hold expenses in your selfDM. They should be immediately added to a closed report and there's nothing to do or prevent. 👍

[NikkiWines]

Cool, I can spin up an issue or PR to handle this, but removing the blocker label for now 👍