[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$125] The emoji icons on reactions are not vertically centered

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.2-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719478843564839

Action Performed:

1. Launch the app
2. Open a report with message
3. Long press on the message for context menu or tap on the react emoji

Expected Result:

The reaction emoji are vertically aligned

Actual Result:

Reaction emoji not vertically aligned

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0141d298ca9ea75ee9
• Upwork Job ID: 1806441888985459900
• Last Price Increase: 2024-06-27
• Automatic offers:
• hoangzinh | Reviewer | 102916247
• neonbhai | Contributor | 102916249

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0141d298ca9ea75ee9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

Upwork job price has been updated to $125

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The emoji icons on reactions are not vertically centered

What is the root cause of that problem?

We intentionally offset the emoji's in EmojiReactionBubble for ios to fix #36739.

App/src/components/Reactions/getEmojiReactionBubbleTextOffsetStyle/index.ios.ts

Line 3 in 27a8d0a

return {transform: [{translateY: 2}]};

This change worked as a hack and is not needed anymore. We can remove it.

What changes do you think we should make in order to solve the problem?

We should remove getEmojiReactionBubbleTextOffsetStyle from EmojiReactionBubble styles here:

App/src/components/Reactions/EmojiReactionBubble.tsx

Line 86 in 27a8d0a

<Text style={[styles.emojiReactionBubbleText, StyleUtils.getEmojiReactionBubbleTextStyle(isContextMenu), getEmojiReactionBubbleTextOffsetStyle()]}>{emojiCodes.join('')}</Text>

​

Since we are not using getEmojiReactionBubbleTextOffsetStyle anywhere else we can remove it from the app.

Result

Screen.Recording.2024-06-28.at.5.16.37.AM.mov

[hoangzinh]

@neonbhai's proposal #44571 (comment) looks good to me

🎀👀🎀 C+ reviewed