[HOLD for payment 2024-07-24] [$250] Expense - Inconsistency in dismissing report details RHP when deleting expense with comments

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.1-10
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Submit an expense to any user with no unsettled expense
3. Go to transaction thread and add some comments
4. Click on the report header > Delete expense > Delete it
5. Note that report details RHP closes
6. Submit two expenses to any user
7. Go to transaction thread of any of the submitted expense
8. Add some comments
9. Click on the report header > Delete expense > Delete it
10. Note that report details RHP does not close

Expected Result:

When deleting expense with comments in the combined report or transaction thread, the behavior of report details RHP (close or not close) should be the same

Actual Result:

In Step 5, when deleting expense with comments in the combined report, report details RHP closes
In Step 10, when deleting expense with comments in the transaction thread, report details RHP does not close

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6523369_1719259702238.20240625_040146.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0129ce6e9afec28c89
• Upwork Job ID: 1805348927110425747
• Last Price Increase: 2024-07-01
• Automatic offers:
• rojiphil | Reviewer | 102947141
• bernhardoj | Contributor | 102947144

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@jasperhuangg FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0129ce6e9afec28c89