[HOLD #44582] Workspace - Distance rate enabled offline when creating the workspace online not grayed

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.0-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): nahummelaku9+A3@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Log in to staging.new.expensify.com
2. Create a new workspace
3. Navigate to more features
4. Go offline
5. Enable Distance rates
6. Navigate to Distance rates

Expected Result:

List of rates should be grayed out.

Actual Result:

List of rates is not grayed out.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6519172_1718870652762.Distance_rate_is_not_grayed_out_when_creating_workspace_online_and_enabling_distance_rate_in_offline.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The distance rates aren't grayed out when enabling the distance rate while offline.

What is the root cause of that problem?

When we create a new workspace, the distance rates are already added to the workspace. When the workspace creating is still pending, we also add it as the distance rate pending action.

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Line 118 in 7512346

(policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD ? policy?.pendingAction : undefined),

After the request is complete, there is no pending action anymore. When we enable the distance rate, the list won't be grayed out because the pending action is already done.

What changes do you think we should make in order to solve the problem?

If we still want to grayed it out when enabling it while offline, then we can add a
policy?.pendingFields?.areDistanceRatesEnabled,
condition so it's grayed out when the distance rate is enabled while offline.

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Lines 113 to 118 in 7512346

	pendingAction:
	value.pendingAction ??
	value.pendingFields?.rate ??
	value.pendingFields?.enabled ??
	value.pendingFields?.currency ??
	(policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD ? policy?.pendingAction : undefined),

[mallenexpensify]

Checking on in  #wave-collect

Noticing a lot of Offline Distance issues lately. Are these being addresses holistically anywhere? (asking cuz I'm assigned to one and considering next steps)

[OfstadC]

This seems pretty similar

[mallenexpensify]

Yeah, please hold here, trying to figure out a holistic plan, since there are a lot of these

[OfstadC]

Sounds good Matt!

[mallenexpensify]

@paultsimura , please comment so I can assign to you