[HOLD for payment 2024-07-10] [$250] Subscription - "common.error.pleaseCompleteForm" is shown when submitting empty survey

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.86-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #43367
Issue reported by: Applause - Internal team

Action Performed:

1. Log in to ND with Gmail account.
2. Go to staging.new.expensify.com/settings/subscription
3. Disable auto-renew toggle.
4. Click Submit without selecting anything.

Expected Result:

Proper error message will be displayed.

Actual Result:

"common.error.pleaseCompleteForm" is shown.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6519286_1718879890831.20240620_123641.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c24a0e46790d2f26
• Upwork Job ID: 1803808097528280767
• Last Price Increase: 2024-06-20
• Automatic offers:
• alitoshmatov | Reviewer | 102813104
• neonbhai | Contributor | 102813106

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 2

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Subscription - "common.error.pleaseCompleteForm" is shown when submitting empty survey

What is the root cause of that problem?

We don't use translate to pass the correct message here:

App/src/components/FeedbackSurvey.tsx

Line 95 in 57663ed

message="common.error.pleaseCompleteForm"

Hence just the string is rendered

What changes do you think we should make in order to solve the problem?

We will use the translate hook to refer to the correct message here:

App/src/components/FeedbackSurvey.tsx

Line 95 in 57663ed

message="common.error.pleaseCompleteForm"

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"common.error.pleaseCompleteForm" is shown as an error message

What is the root cause of that problem?

In FeedBackSurvey component we are passing 'common.error.pleaseCompleteForm' key as a value to message prop instead of calling translate method with the key to fetch the error message from en.ts and es.ts.

App/src/components/FeedbackSurvey.tsx

Lines 92 to 95 in 6dc6f81

	<FormAlertWithSubmitButton
	isAlertVisible={shouldShowReasonError}
	onSubmit={handleSubmit}
	message="common.error.pleaseCompleteForm"

What changes do you think we should make in order to solve the problem?

Pass translate('common.error.pleaseCompleteForm') to message prop here

What alternative solutions did you explore? (Optional)

[carlosmiceli]

Can't reproduce in prod, but it seems to be a new feature to show subscription inside ND.