[HOLD for payment 2024-07-10] [$250] Error message when sign up for phone number with a country code

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.85-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @justinpersaud
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1718810502321919

Action Performed:

1. Go to staging.new.expensify.com
2. Enter a phone number with country code but not + at the front

Expected Result:

Able to sign up

Actual Result:

Error message Please enter a valid phone number, with the country code (e.g. +15005550006)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.233.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016f018eaf42305358
• Upwork Job ID: 1803578141280635162
• Last Price Increase: 2024-06-26
• Automatic offers:
• allgandalf | Reviewer | 102889904
• nkdengineer | Contributor | 102889905

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016f018eaf42305358

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[justinpersaud]

@lschurr i think that error might actually be coming from the backend so it may be an issue we need to solve there

[botarchiveforandy]

Proposal

---

Please re-state the problem that we are trying to solve in this issue.

Enter a phone number with country code but not + at the front will cause error "not valid phone number"

What is the root cause of that problem?

The input phone number without + at the front will be appended with country code again in this function called by validate() in src/pages/signin/LoginForm/BaseLoginForm.tsx

src/libs/ValidationUtils.ts

function appendCountryCode(phone: string): string {
   return phone.startsWith('+') ? phone : `+${countryCodeByIP}${phone}`;
}

What changes do you think we should make in order to solve the problem?

I think we can handle the this case in function appendCountryCode() which becomes:

    if (phone.startsWith('+')) {
       return phone;
   }
   if (phone.startsWith(countryCodeByIP)) {
       return `+${phone}`;
   }
   return `+${countryCodeByIP}${phone}`;

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 @yuxian0908! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[botarchiveforandy]

Contributor details
Your Expensify account email: andyretajeff@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~010062ad34020e086f

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!