[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Distance- Billable toggle is not auto-enabled for distance expense submitted via QAB

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): berhanesarah.testing+@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Admin - OldDot

1. Navigate to the collect workspace settings > Expenses
2. Set the "Re-bill expenses to clients" to "Default to Billable"
   NewDot
3. Submit a distance expenses via FAB(not QAB) to the collect workspace
4. Observe that there's a billable toggle and it's enabled
5. Submit the expense
6. Go to FAB and submit a distance expense via QAB

Expected Result:

The billable toggle is enabled

Actual Result:

The billable toggle is not auto-enabled. There is an inconsistency between expenses submitted via FAB and QAB

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6512118_1718293301409.Expensify_-_Workspace_Editor_-_Google_Chrome_2024-06-13_11-26-59.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ed23a1d39f78d70b
• Upwork Job ID: 1801639101192340538
• Last Price Increase: 2024-06-14
• Automatic offers:
• eh2077 | Reviewer | 102815454
• truph01 | Contributor | 102815456

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The billable toggle is not auto-enabled. There is an inconsistency between expenses submitted via FAB and QAB

What is the root cause of that problem?

• We always skip confirmation page one when clicking on quick action button:
  

  App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

  Lines 229 to 231 in 9ddc788

  	case CONST.QUICK_ACTIONS.REQUEST_DISTANCE:
  	IOU.startMoneyRequest(CONST.IOU.TYPE.SUBMIT, quickActionReportID, CONST.IOU.REQUEST_TYPE.DISTANCE, true);
  	return;

  
  but the billable is only set via:
  

  App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

  Lines 161 to 164 in 9ddc788

  	const defaultBillable = !!policy?.defaultBillable;
  	useEffect(() => {
  	IOU.setMoneyRequestBillable(transactionID, defaultBillable);
  	}, [transactionID, defaultBillable]);

What changes do you think we should make in order to solve the problem?

• We can set the billable data via this logic:
  

  App/src/pages/iou/request/step/IOURequestStepDistance.tsx

  Line 291 in 9ddc788

  false,

  by using

                    defaultBillable ?? false,

with:

                const defaultBillable = !!policy?.defaultBillable; 

What alternative solutions did you explore? (Optional)

• We can do not skip comfirmation screen in this:
  

  App/src/libs/actions/IOU.ts

  Line 358 in 9ddc788

  Onyx.set(`${ONYXKEYS.COLLECTION.SKIP_CONFIRMATION}${transactionID}`, skipConfirmation);

  
  if the shouldShowBillable = policy?.disabledFields?.defaultBillable === false is true

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ed23a1d39f78d70b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[eh2077]

To have expected consistent results, I think it makes sense to opt in default billable property in IOURequestStepDistance. So @truph01 's proposal looks good to me.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @johnmlee101, see https://stackoverflow.com/c/expensify/questions/7972 for more details.