[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Message - Send button not response in mobile view and after returning to normal view

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.82-4
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Open any chat
2. Send message by clicking on Send button
3. Open DevTools console
4. Switch to mobile view
5. Type a message
6. Click on Send Button

Expected Result:

Message sent in mobile view as in normal

Actual Result:

Send button not response. Also, after returning to normal view, Send button not response. User need to reload page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6511866_1718276240791.mobile_view.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013bc99e56ff65d5ac
• Upwork Job ID: 1801304586589536855
• Last Price Increase: 2024-06-13
• Automatic offers:
• hoangzinh | Reviewer | 102782090
• truph01 | Contributor | 102782092

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013bc99e56ff65d5ac

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[vaib-contrib]

Proposal

Please re-state the problem that we are trying to solve in this issue.

issue is reproducible from the steps mentioned in the issue.
In browser, send message button from the chat doesn't register tap event when responsive-mode is turned-on-and-or-off from devtools, until the browser is refreshed.

What is the root cause of that problem?

For send button, we are using GestureDetector from react-native-gesture-handler lib's tap gesture, which is not necessary, and a quick search through codebase results in about 2 places where GestureDetector is used exclusively for tap interactions, while in other cases, PressableWithFeedback or PressableWithoutFeedback is used.

Places where GestureDetector is used for detecting a tap:

1. Send Button (related to this issue)
   

   App/src/pages/home/report/ReportActionCompose/SendButton.tsx

   Lines 34 to 36 in 361a000

   	onMouseDown={(e) => e.preventDefault()}
   	>
   	<GestureDetector gesture={Tap}>

other two places...

2. IOURequestStepScan (may be affected)

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Lines 488 to 490 in d565bb1

	{cameraPermissionStatus === RESULTS.GRANTED && device != null && (
	<View style={[styles.cameraView]}>
	<GestureDetector gesture={tapGesture}>

3. MagicCodeInput (may be affected)

App/src/components/MagicCodeInput.tsx

Lines 362 to 363 in 6c3f605

	<View style={[styles.magicCodeInputContainer]}>
	<GestureDetector gesture={tapGesture}>

## What changes do you think we should make in order to solve the problem? The straight forward solution would be to remove the `GestureDetector` wrapper, and use `TouchableWithFeedback`'s `onPress` callback instead. I have tested it locally, and it works fine.

The SendButton component would look like:

  <View
        style={styles.justifyContentEnd}
        // Keep focus on the composer when Send message is clicked.
        onMouseDown={(e) => e.preventDefault()}
    >
        <Tooltip text={translate('common.send')}>
          <PressableWithFeedback
              style={({pressed, isDisabled}) => [
                  styles.chatItemSubmitButton,
                  isDisabledProp || pressed || isDisabled ? undefined : styles.buttonSuccess,
                  isDisabledProp ? styles.cursorDisabled : undefined,
              ]}
              role={CONST.ROLE.BUTTON}
              accessibilityLabel={translate('common.send')}
              disabled={isDisabledProp}
              onPress={handleSendMessage}
          >
            ...

What alternative solutions did you explore? (Optional)

Thinking of confirming if it's an upstream issue with react-native-gesture-handler library for web, if we really need to use GestureDetector in this particular case.

[melvin-bot]

📣 @vaib-contrib! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!