[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Send invoice - Two unread markers when marking message unread in invoice thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Send invoice
3. Enter amount, select participant and send the invoice
4. Go to invoice thread
5. Send a message
6. Right click on the message > Mark as unread

Expected Result:

There will be one unread marker above the message

Actual Result:

There are two unread markers above the message
If the invoice currency is foreign currency, three unread markers will show up - another one is below Total row

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6510682_1718190308179.20240612_190249.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0172ef4f418ef0c267
• Upwork Job ID: 1801658282966992916
• Last Price Increase: 2024-06-14
• Automatic offers:
• suneox | Reviewer | 102768842

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-bills

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are two unread markers above the message
If the invoice currency is foreign currency, three unread markers will show up - another one is below Total row

What is the root cause of that problem?

We are miscalculating shouldUseThreadDividerLine here in case it is an invoice report

What changes do you think we should make in order to solve the problem?

Will return true when it is an invoice report

return ReportUtils.isExpenseReport(report) || ReportUtils.isIOUReport(report) || ReportUtils.isInvoiceReport(report);

App/src/pages/home/report/ReportActionsList.tsx

Line 487 in 2e85794

return ReportUtils.isExpenseReport(report) || ReportUtils.isIOUReport(report);

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0172ef4f418ef0c267

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)