[HOLD for payment 2024-06-28] [$250] Extra spaces are not trimmed in the next page for the routing number and Account number

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.79-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allgandalf
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717537508312169

Action Performed:

1. Go to a workspace
2. Enable workflows
3. Click on connect bank account
4. Select manual and enter the account details as : 011401533 and account number 1111222233331111 give some space before both these numbers and press next

Expected Result:

Spaces are trimmed in the confirmation page

Actual Result:

Spaces are present on the confirmation page, we should trim them while saving as a account number cannot have spaces before or after.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-06-05.at.3.11.25.AM.mov

Recording.176.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0134151ac2072ab6de
• Upwork Job ID: 1798588655835680495
• Last Price Increase: 2024-06-06
• Automatic offers:
• allgandalf | Contributor | 102633932
• Krishna2323 | Contributor | 102704572

Issue Owner

Current Issue Owner: @MitchExpensify / @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[allgandalf]

@Christinadobrzyn Can i be the C+ here? as i reported this issue and have more context about the same.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Extra spaces are not trimmed in the next page for the routing number and Account number

What is the root cause of that problem?

We are not using useStepFormSubmit in Manual. useStepFormSubmit saves the trimmed value (that is passed by FormProvider onSubmit) as the new draft.

App/src/pages/ReimbursementAccount/BankInfo/substeps/Manual.tsx

Line 65 in 088939b

onSubmit={onNext}

What changes do you think we should make in order to solve the problem?

Use useReimbursementAccountStepFormSubmit like we do in other components and for input wrappers pass shouldSaveDraft={!isEditing}

App/src/pages/ReimbursementAccount/PersonalInfo/substeps/FullName.tsx

Lines 52 to 56 in 088939b

	const handleSubmit = useReimbursementAccountStepFormSubmit({
	fieldIds: STEP_FIELDS,
	onNext,
	shouldSaveDraft: isEditing,
	});

    const handleSubmit = useReimbursementAccountStepFormSubmit({
        fieldIds: [BANK_INFO_STEP_KEYS.ROUTING_NUMBER, BANK_INFO_STEP_KEYS.ACCOUNT_NUMBER],
        onNext,
        shouldSaveDraft: isEditing,
    });

We will also check for other pages like this, which uses substeps.

What alternative solutions did you explore? (Optional)

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Extra spaces are not trimmed in the next page for the routing number and Account number

What is the root cause of that problem?

Values saved from Manual step with spaces and used on the next step.

App/src/pages/ReimbursementAccount/BankInfo/substeps/Manual.tsx

Lines 73 to 76 in 952d844

	<InputWrapper
	InputComponent={TextInput}
	ref={inputCallbackRef}
	inputID={BANK_INFO_STEP_KEYS.ROUTING_NUMBER}

What changes do you think we should make in order to solve the problem?

The best way to solve this issue id to make sure we don't go to the next step with wrong values (with spaces).

I suggest adding a more check on Manual step to make sure we don't accept values with spaces. This will make sure all values sent to the next steps and saved on the Onyx data are correct and safe

App/src/pages/ReimbursementAccount/BankInfo/substeps/Manual.tsx

Line 40 in 952d844

const validate = useCallback((values: FormOnyxValues<typeof ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM>): FormInputErrors<typeof ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM> => {

1- The values sent to the validate function are trimmed by default. You can console.log values and you will see that the space added on the form is not within those values

App/src/pages/ReimbursementAccount/BankInfo/substeps/Manual.tsx

Line 40 in 952d844

const validate = useCallback((values: FormOnyxValues<typeof ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM>): FormInputErrors<typeof ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM> => {

for this we need to add shouldTrimValues={false} to FormProvider so we can validate the correct values.

App/src/pages/ReimbursementAccount/BankInfo/substeps/Manual.tsx

Line 63 in 952d844

<FormProvider

2- We need to add a new regex for spaces before and after
We can add a new const

REGEX: {
  US_ACCOUNT_NUMBER: /^[0-9]{4,17}$/,
  MASKED_US_ACCOUNT_NUMBER: /^[X]{0,13}[0-9]{4}$/,
  SWIFT_BIC: /^[A-Za-z0-9]{8,11}$/,
+ START_OR_END_WITH_SPACE: /^\s|\s$/,
},

3- We update the validate function to check if the values has spaces at the start or at the end

if (values.accountNumber  &&  CONST.BANK_ACCOUNT.REGEX.START_OR_END_WITH_SPACE.test(values.accountNumber)) {
  errors.accountNumber  =  'bankAccount.error.accountNumber';
}

We do the same for the routingNumber

What alternative solutions did you explore?

[Christinadobrzyn]

@allgandalf I'm going to add the label so it's fair share but we can ask the assigned C+ if you can take it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0134151ac2072ab6de

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)