[HOLD for payment 2024-06-28] [$250] Taxes - Selected tax rate for Workspace currency default can be unselected which causes error

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.77-8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4584734
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings
3. Go to Taxes (enable it if not enabled)
4. Click Settings
5. Click Workspace currency default
6. Click on the selected tax rate

Expected Result:

App will not unselect the tax rate since Workspace currency default must have a tax rate

Actual Result:

The selected tax rate is unselected which results in a blank tax rate created with error "Invalid tax for default currency". The error message cannot be dismissed too
After unselecting the tax rate, the tax rate is selected again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6496493_1717088280521.20240531_005324.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f0cd7866af3328d2
• Upwork Job ID: 1796250642764570624
• Last Price Increase: 2024-06-06
• Automatic offers:
• DylanDylann | Contributor | 102691550
• dominictb | Contributor | 102691783

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Taxes - Selected tax rate for Workspace currency default can be unselected which causes error

What is the root cause of that problem?

Before updating the tax we don't check if the selected tag is the same as the new selected tag.

App/src/pages/workspace/taxes/WorkspaceTaxesSettingsWorkspaceCurrency.tsx

Lines 36 to 39 in 6af6811

	const submit = (taxes: OptionsListUtils.TaxRatesOption) => {
	setWorkspaceCurrencyDefault(policyID, taxes.code ?? '');
	Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
	};

App/src/pages/workspace/taxes/WorkspaceTaxesSettingsForeignCurrency.tsx

Lines 36 to 39 in 6af6811

	const submit = (taxes: OptionsListUtils.TaxRatesOption) => {
	setForeignCurrencyDefault(policyID, taxes.code ?? '');
	Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
	};

What changes do you think we should make in order to solve the problem?

Only update the tax when the new selected tax is different from the previous selected tag.

        if (selectedTaxRate !== taxes.text) {
            setWorkspaceCurrencyDefault(policyID, taxes.code ?? '');
        }

Add the same in WorkspaceTaxesSettingsForeignCurrency if required.

What alternative solutions did you explore? (Optional)

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Selected tax rate for Workspace currency default can be unselected which causes error

What is the root cause of that problem?

We are not returning early if the tax rate is same just like we do here

App/src/libs/actions/Report.ts

Lines 1929 to 1934 in 6af6811

	function updateDescription(reportID: string, previousValue: string, newValue: string) {
	// No change needed, navigate back
	if (previousValue === newValue) {
	Navigation.goBack(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(reportID));
	return;
	}

What changes do you think we should make in order to solve the problem?

We should early return from here and here just like we do here. We can pass previousTaxCode and then compare it with new one and then we can early return from the functions.

Here we are navigating back but in the case of taxes we can just early return. No need to navigate back, we are navigating here

App/src/libs/actions/Report.ts

Lines 1929 to 1934 in 6af6811

	function updateDescription(reportID: string, previousValue: string, newValue: string) {
	// No change needed, navigate back
	if (previousValue === newValue) {
	Navigation.goBack(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(reportID));
	return;
	}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f0cd7866af3328d2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)