[HOLD for payment 2024-06-20] [$250] [HIGH] [API] OpenPaymentsPage is called whenever SettlementButton is rendered breaking 1:1:1

[mountiny]

Coming from here

Problem

When user is expected to pay an expense report, in the Report preview or in the expense report header we render the SettlementButton. This calls OpenPaymentsPage API in the useEffect to determine if user can use Wallet.

This breaks 1:1:1 though as we should return this information in the OpenReport call or somewhere else.

Solution

I believe the necessary data should be returned from the OpenApp. Let's remove this API call and see if there are any regressions in the payment flow

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0150686ef5eeacf118
• Upwork Job ID: 1795838347802320896
• Last Price Increase: 2024-05-29
• Automatic offers:
• fedirjh | Reviewer | 102518263
• abzokhattab | Contributor | 102518266

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0150686ef5eeacf118

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

OpenPaymentsPage is called whenever SettlementButton is rendered breaking 1:1:1

What is the root cause of that problem?

Feature request.

What changes do you think we should make in order to solve the problem?

Remove OpenPaymentsPage call from here

App/src/components/SettlementButton.tsx

Lines 146 to 148 in 2a7d5d4

	useEffect(() => {
	PaymentMethods.openWalletPage();
	}, []);

What alternative solutions did you explore? (Optional)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

OpenPaymentsPage is called whenever SettlementButton is rendered breaking 1:1:1

What is the root cause of that problem?

we need to remove the OpenPaymentsPage as its now redundant because the data are already returned in theopenAPI request:

What changes do you think we should make in order to solve the problem?

Remove the followinguseEffect call

App/src/components/SettlementButton.tsx

Lines 146 to 148 in 2a7d5d4

	useEffect(() => {
	PaymentMethods.openWalletPage();
	}, []);