[HOLD for payment 2024-07-10] [$250] Workspace's default currency isn't showing when submitting a request

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.75-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1716540568640839

Action Performed:

1. Create a new WS
2. Change the currency of the workspace
3. Go to the WS chat
4. Tapping on the plus icon > Submit expense
5. Notice the currency in amount step

Expected Result:

The default currency in the amount step should be the WS currency if we submit an expense in the WS chat.

Actual Result:

The default currency in the amount step isn't the WS currency

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.121.mp4

Screen.Recording.2024-05-24.at.15.51.19.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ce85c0267e9bbc85
• Upwork Job ID: 1795970316320600064
• Last Price Increase: 2024-06-06
• Automatic offers:
• fedirjh | Reviewer | 102671509
• ShridharGoel | Contributor | 102671511

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dukenv0307]

I'm happy to take over this issue as C+ since I'm the reporter for this bug and have more context in this bug.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The default currency in the amount step isn't the WS currency

What is the root cause of that problem?

When we init money request, we always set the default currency as the local currency of the user

App/src/libs/actions/IOU.ts

Line 320 in 8d73db3

currency: currentUserPersonalDetails.localCurrencyCode ?? CONST.CURRENCY.USD,

What changes do you think we should make in order to solve the problem?

We should prioritize the policy's currency first instead of user's local currency

currency: policy?.outputCurrency ?? currentUserPersonalDetails.localCurrencyCode ?? CONST.CURRENCY.USD,

App/src/libs/actions/IOU.ts

Line 320 in 8d73db3

currency: currentUserPersonalDetails.localCurrencyCode ?? CONST.CURRENCY.USD,

What alternative solutions did you explore? (Optional)

NA

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Policy currency is not being used when adding a money request and in teachers unite. Also, when workspace is made using iou report, then report currency is not being used.

What is the root cause of that problem?

Policy currency is not being used in initMoneyrequest:

App/src/libs/actions/IOU.ts

Line 320 in 525ad6f

currency: currentUserPersonalDetails.localCurrencyCode ?? CONST.CURRENCY.USD,

Also, policy currency is not being used in TeachersUnite:

App/src/libs/actions/TeachersUnite.ts

Line 98 in 525ad6f

outputCurrency: allPersonalDetails?.[sessionAccountID]?.localCurrencyCode ?? CONST.CURRENCY.USD,

Then, there's one more bug. When creating a workspace using report, the report's currency should be set as the default for the workspace but that is not happening as of now.

App/src/libs/actions/Policy.ts

Lines 2039 to 2040 in 525ad6f

	function buildOptimisticCustomUnits(): OptimisticCustomUnits {
	const currency = allPersonalDetails?.[sessionAccountID]?.localCurrencyCode ?? CONST.CURRENCY.USD;

Just the localCurrencyCode is being used.

What changes do you think we should make in order to solve the problem?

We should use policy?.outputCurrency in the optimistic data when initing the money request:

Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${newTransactionID}`, {
    amount: 0,
    comment,
    created,
    currency: policy?.outputCurrency ?? currentUserPersonalDetails.localCurrencyCode ?? CONST.CURRENCY.USD,
    iouRequestType,
    reportID,
    transactionID: newTransactionID,
    isFromGlobalCreate,
    merchant: CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT,
    splitPayerAccountIDs: [currentUserPersonalDetails.accountID],
});

Update it in TeachersUnite.ts:

const optimisticData: OnyxUpdate[] = [
{
    onyxMethod: Onyx.METHOD.SET,
    key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
    value: {
        id: policyID,
        isPolicyExpenseChatEnabled: true,
        type: CONST.POLICY.TYPE.CORPORATE,
        name: policyName,
        role: CONST.POLICY.ROLE.USER,
        owner: sessionEmail,
        outputCurrency: getPolicy(policy)?.outputCurrency ?? allPersonalDetails?.[sessionAccountID]?.localCurrencyCode ?? CONST.CURRENCY.USD,
        employeeList: {
            [sessionEmail]: {
                role: CONST.POLICY.ROLE.USER,
                errors: {},
            },
        },
        pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
    },
},

Pass currency via iouReport:

const {customUnits, customUnitID, customUnitRateID} = buildOptimisticCustomUnits(iouReport.currency);

Now, it can be used in buildOptimisticCustomUnits:

function buildOptimisticCustomUnits(reportCurrency?: string): OptimisticCustomUnits {
    const currency = reportCurrency ?? allPersonalDetails?.[sessionAccountID]?.localCurrencyCode ?? CONST.CURRENCY.USD;
.....

[melvin-bot]

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@puneetlath Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ce85c0267e9bbc85