[HOLD for payment 2024-06-05] HIGH: [API Reliability] Unused pusher subscriptions are not unsubscribed

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.74-4
Reproducible in staging?: yes
Reproducible in production?: yes
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1716338088626339

Action Performed:

1. Open NewDot
2. Click on a few different reports.
3. Open the Chrome Dev Tools, network tab. Filter for AuthenticatePusher
4. Close your laptop, wait 10 seconds.
5. Open your laptop.

Expected Result:

We should only use AuthenticatePusher to reconnect to the channels you need to be actively connected to.

Actual Result:

We use AuthenticatePusher to reconnect to the channels for all the reports you clicked into in the first steps. This leads to a number of unnecessary network requests and websocket connections.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

Observed on Chrome desktop, but affects all platforms.

Screenshots/Videos

n/a

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[roryabraham]

Created #42447 to fix this.

[roryabraham]

Posted a proposal here