[HOLD for payment 2024-06-28] [$250] mWeb - Workspace - Wrong members number is displayed

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.74-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4563078
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Create a workspace
2. Invite one member
3. Navigate to the workspace chat with the invited member.
4. Click on the header to go to the details page
5. Notice that the members number is displayed as 4.
6. Click on members, Notice that only 3 members are there.

Expected Result:

members number displayed is equal to the workspace members

Actual Result:

members number is displayed as 4 when there are only 3 members.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6482490_1715848025963.video_2024-05-16_11-25-31.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @alexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0110eb98a4dc986510
• Upwork Job ID: 1792305587832528896
• Last Price Increase: 2024-06-02
• Automatic offers:
• alitoshmatov | Reviewer | 102574059
• nkdengineer | Contributor | 102574060

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

members number is displayed as 4 when there are only 3 members.

What is the root cause of that problem?

• When calling API AddMembersToWorkspace to add the account which did not signed in yet, we create an optimistic accountID for this account, then add that accountID to the workspaceMemberChats.participants.

• Then when the API is called successfully, BE returns another accountID that also points to the invited user and it is added to workspaceMemberChats.participants.

• Now, workspaceMemberChats.participants contains two accountID that point to one user.

• The number of members displayed in ReportDetailsPage is from activeChatMembers, and as we can see, the wrong members number is displayed. And the participants to display in ReportParticipantsPage are from here, where we have a logic:
  

  App/src/pages/ReportParticipantsPage.tsx

  Lines 76 to 80 in e8ae3c5

  	const details = personalDetails?.[accountID];
  	if (!details) {
  	Log.hmmm(`[ReportParticipantsPage] no personal details found for Group chat member with accountID: ${accountID}`);
  	return;
  	}

  
  which will filter out the accountID that does not have personalDetails?.[accountID].

What changes do you think we should make in order to solve the problem?

• In activeChatMembers, we should only get the accountID that has personalDetails[accountID] like we did when getting the participants to display in here

What alternative solutions did you explore? (Optional)

• We can remove the optimistic accountID from the report's participant once the API is called successfully.
• To do it, in here:

                participants: {
                    [accountID]: allPersonalDetails[accountID] ? {} : null,
                },

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Current assignee @adelekennedy is eligible for the Bug assigner, not assigning anyone new.