[HOLD for payment 2024-06-20] [$250] Workspace switcher resets to All (Expensify) after page refresh

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.73-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1715648972336829

Action Performed:

1. Go the staging.new.expensify.com and login
2. Click the dropdown on the top left and choose different workspace
3. Refresh the page

Expected Result:

The selected workspace should remain the same

Actual Result:

The workspace switcher changes back to all (still filtering based on the workspace picked, but the icon and title resets back to Expensify)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

WS.Filter.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016d7c9a80aa03fdc3
• Upwork Job ID: 1792505861453303808
• Last Price Increase: 2024-05-20
• Automatic offers:
• c3024 | Reviewer | 102452994
• abzokhattab | Contributor | 102452997

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[shawnborton]

FWIW, this was originally reported by @GandalfGwaihir

[m-natarajan]

Solution from reporter @GandalfGwaihir : We need to subscribe to the active policy using Onyx in the WorkspaceSwitcherButton component, we used to do this but in Ideal nav 2 PR, we removed it and shifted the subscription to the TopBar component, this caused the bug.

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Switcher resets to Expensify icon on page refresh

What is the root cause of that problem?

When we refresh the Page, the page remounts and the Policy prop passed becomes undefined for the Switcher Icon component:

App/src/components/WorkspaceSwitcherButton.tsx

Line 23 in a6cb60c

function WorkspaceSwitcherButton({policy}: WorkspaceSwitcherButtonProps) {

What changes do you think we should make in order to solve the problem?

We should subscribe to the active Policy using Onyx in the component WorkspaceSwitcherButton, this will make sure that every time the page remounts, we are able to access the latest policy information.

We should also get the activeWorkspaceID from the Topbar and pass it down to the WorkspaceSwitcherButton this will help us in getting the policy details from Onyx.

Result:

Screen.Recording.2024-05-14.at.7.43.13.PM.mov

[melvin-bot]

@trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

Interesting! @GandalfGwaihir @shawnborton I can reproduce this one, but only in this condition:

1. Click on the chats tab
2. Switch to a different workspace
3. Click the avatar in the bottom tab bar
4. Refresh the page
5. Click the chats tab in the bottom tab
6. Observe the workspace has reverted back to the Expensify "All" view

2024-05-20_11-35-52.mp4

As you can see in the video above, if I just refresh while on the Chats tab, it doesn't revert back to the All view.

CC: @adamgrzybowski @WojtekBoman @mountiny for vis on this as well.