[HOLD for payment 2024-06-20] [$250] mWeb -Room - Inconsistency while pasting highlighted mention in room and expense description

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.72
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1.Go to https://staging.new.expensify.com/
2. Tap FAB > Start a Chat > create a new room
3. Copy the following text in chat

@ApplauseTester++0411km
@jaihanumanblog@gmail.com
(notice: first mention selected from list, second mention is highlighted)

4. Tap header

5. Paste text in room description

6. Note second mention is not highlighted

7. Navigate to LHN

8. Tap fab -- track expense

9. Enter amount and tap next

10. Paste the same above text in track expense description

11. Note now second mention is highlighted and displayed

Expected Result:

There should not be inconsistency while pasting highlighted mention in room and expense description

Actual Result:

Inconsistency while pasting highlighted mention in room and expense description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6475789_1715253066288.inconsistency.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c4a08b3d6f351b65
• Upwork Job ID: 1790309855227322368
• Last Price Increase: 2024-05-14
• Automatic offers:
• shubham1206agra | Reviewer | 0
• tienifr | Contributor | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @garrettmknight / @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When pasting a mention to room description, it's not rendered as a mention but still as a plain text. But if we paste it to money request description, the mention is rendered as mention markdown.

What is the root cause of that problem?

In money request description page, we enable the live markdown preview

App/src/pages/iou/request/step/IOURequestStepDescription.tsx

Line 182 in 807c945

isMarkdownEnabled

but we don't enable it in the room description.

App/src/pages/RoomDescriptionPage.tsx

Lines 81 to 100 in 807c945

	<InputWrapper
	InputComponent={TextInput}
	inputID={INPUT_IDS.REPORT_DESCRIPTION}
	label={translate('reportDescriptionPage.roomDescription')}
	accessibilityLabel={translate('reportDescriptionPage.roomDescription')}
	role={CONST.ROLE.PRESENTATION}
	autoGrowHeight
	maxAutoGrowHeight={variables.textInputAutoGrowMaxHeight}
	maxLength={CONST.REPORT_DESCRIPTION.MAX_LENGTH}
	ref={(el: BaseTextInputRef | null): void => {
	if (!el) {
	return;
	}
	reportDescriptionInputRef.current = el;
	updateMultilineInputRange(el);
	}}
	value={description}
	onChangeText={handleReportDescriptionChange}
	autoCapitalize="none"
	/>

What changes do you think we should make in order to solve the problem?

Enable the live markdown in room description by passing isMarkdownEnabled to the input.

we can do the same for other input that support markdown too

[Christinadobrzyn]

I don't think this is a bug,

From what I can test, the only time the
@jaihanumanblog@gmail.com isn't highlighted is after it's copied and pasted but before it's 'saved' in the room/expense/description. Once saved it turns into a mention and is highlighted.

@bernhardoj let me know if you feel otherwise but I'm going to close this as an edge case, small incident.

[bernhardoj]

From what I can test, the only time the
@jaihanumanblog@gmail.com isn't highlighted is after it's copied and pasted but before it's 'saved' in the room/expense/description. Once saved it turns into a mention and is highlighted.

@Christinadobrzyn That's true. To simplify it, the room description page currently doesn't enable the live markdown preview, while the expense/task description enables it. So, if we want to enable the live markdown preview for room description too, then we can reopen this.

Btw, there is a previous discussion here to enable the live markdown preview on some inputs, but looks like the room description page is missing from the list.

[bernhardoj]

@Christinadobrzyn bump

[Christinadobrzyn]

Ah sorry @bernhardoj this GH was closed so I didn't see this. Ah yes, we should work on this based on this convo - https://expensify.slack.com/archives/C01GTK53T8Q/p1711641837108169

Although, I'm wondering if these markdowns are on hold based on this Slack convo - https://expensify.slack.com/archives/C01GTK53T8Q/p1711641837108169 I'll ask in that chat: Answer - no need to hold- let's work on these now.