[$250] [Track tax] Send invoice - Tax amount does not update after selecting a tax rate

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41524

Action Performed:

Precondition:

• Workspace has enabled taxes

1. Go to staging.new.expensify.com
2. Go to FAB > Send invoice
3. Enter amount and select a user
4. On confirmation page, select the workspace with taxes
5. Send the invoice
6. In invoice chat, click on the invoice preview
7. Click Tax
8. Select a tax rate

Expected Result:

Tax amount will update after selecting a tax rate

Actual Result:

Tax amount does not update after selecting a tax rate

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6473979_1715100106426.20240508_003712.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e647d43a762c1223
• Upwork Job ID: 1788212378196783104
• Last Price Increase: 2024-05-08

Issue Owner

Current Issue Owner: @s77rt

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[gijoe0295]

#41524 was reverted and I could reproduce this on production.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tax amount does not update IMMEDIATELY after selecting a tax rate but delay until API call succeeded.

What is the root cause of that problem?

Only the taxRate is updated optimistically, the tax amount need calculation from server to display:

App/src/libs/actions/IOU.ts

Lines 2817 to 2819 in d63b5a6

	const transactionChanges = {
	taxCode,
	};

What changes do you think we should make in order to solve the problem?

We need to optimistically update taxAmount according to taxRate.

1. Move the logic for amount calculation up:

App/src/pages/iou/request/step/IOURequestStepTaxRatePage.tsx

Lines 81 to 90 in ff368b8

	if (!transaction || !taxes.text || !taxRates) {
	Navigation.goBack(backTo);
	return;
	}
	const taxAmount = getTaxAmount(taxRates, taxes.text, transaction?.amount);
	if (taxAmount === undefined) {
	Navigation.goBack(backTo);
	return;
	}
	const amountInSmallestCurrencyUnits = CurrencyUtils.convertToBackendAmount(taxAmount);

2. Include taxAmount in updateMoneyRequestTaxRate:

App/src/libs/actions/IOU.ts

Line 2828 in d63b5a6

policy?: OnyxEntry<OnyxTypes.Policy>;

What alternative solutions did you explore? (Optional)

NA

[joekaufmanexpensify]

Yeah, it's not working for me either. When I select tax rate, we just say I updated the expense, but don't actually add the new tax amount:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e647d43a762c1223

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)