[PAID] [$250] [Help Wanted] Taxes settings – Default tax rates greyed out when go offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.70-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4537105
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with Expensifail account
3. Create a new workspace
4. Navigate to the workspace editor
5. Navigate to "More Features"
6. Enable the tax toggle
7. Verify that there are two default tax rates, Tax exempt and Tax Rate 1
8. Go offline on your devise

Expected Result:

Default tax rates are not greyed out when go offline

Actual Result:

Default tax rates greyed out when go offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6469248_1714675740504.Default_tax_rates_greyed_out.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0139092aa29d144f77
• Upwork Job ID: 1795925349459288064
• Last Price Increase: 2024-05-29
• Automatic offers:
• DylanDylann | Reviewer | 102763779
• cretadn22 | Contributor | 102763780

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Default workflow should be greyed out when go offline
• Default distance rate should be greyed out when go offline

What is the root cause of that problem?

When creating the optimistic policy we don't add pending fields for these section

What changes do you think we should make in order to solve the problem?

1. workflow section

In these places

App/src/libs/actions/Policy/Policy.ts

Line 1433 in bdb9789

function createDraftInitialWorkspace(policyOwnerEmail = '', policyName = '', policyID = generatePolicyID(), makeMeAdmin = false) {

App/src/libs/actions/Policy/Policy.ts

Line 1482 in bdb9789

function buildPolicyData(policyOwnerEmail = '', makeMeAdmin = false, policyName = '', policyID = generatePolicyID(), expenseReportId?: string) {

App/src/libs/actions/Policy/Policy.ts

Line 1760 in bdb9789

function createDraftWorkspace(policyOwnerEmail = '', makeMeAdmin = false, policyName = '', policyID = generatePolicyID()): CreateWorkspaceParams {

App/src/libs/actions/Policy/Policy.ts

Line 2005 in bdb9789

function createWorkspaceFromIOUPayment(iouReport: Report | EmptyObject): string | undefined {

We need to add pendingFields to optimistic data

pendingFields: {
    autoReporting: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
    approvalMode: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
    reimbursementChoice: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
}

2. Distance rate section
   in this place
   

   App/src/libs/actions/Policy/Policy.ts

   Line 1393 in 95c8202

   function buildOptimisticCustomUnits(): OptimisticCustomUnits {

Need to add

pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD

Additionally, require updating the successData and failureData to reset these pending fields.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@strepanier03 Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[strepanier03]

I'm unable to reproduce this on Mac/Chrome or Android Native with an Expensifail account. Below is Mac/Chrome testing. The default tax rates don't grey out when I go offline.

2024-05-07_16-11-03.mp4