[$500] HIGH: [Reliability] Unable to search and start chat with a new user

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.64-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713813518935569

Action Performed:

1. Open chat finder clicking search icon
2. Type any email address of a new user who does not have expensify account

Expected Result:

Should be able to start chat with the new user

Actual Result:

No results found error message appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.3020.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c732e2d542ec4ad2
• Upwork Job ID: 1782814314054311936
• Last Price Increase: 2024-04-23
• Automatic offers:
• nkdengineer | Contributor | 0
• DylanDylann | Contributor | 0

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[stephanieelliott]

Reapplying the Bug label to get another BZ member on this while I am OOO til May 2. Thanks @sakluger, I'll grab this back from you when I return!

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Extra bottom margin below green button in Personal info page

What is the root cause of that problem?

on ChatFinderPage, what ever the search inside the input, we turn results only from existing reports.
We always turn Null to userToInvite

App/src/pages/ChatFinderPage/index.tsx

Line 109 in 944751f

userToInvite: null,

What changes do you think we should make in order to solve the problem?

as we do on NewChatPage,

App/src/pages/NewChatPage.tsx

Line 55 in 944751f

const filteredOptions = OptionsListUtils.getFilteredOptions(

We need to use getFilteredOptions with the debouncedSearchTerm to get back the new userToInvite

update here to:

const filteredOptions = useMemo(() => {
        if (debouncedSearchValue.trim() === '') {
            return {
                recentReports: [],
                personalDetails: [],
                userToInvite: null,
                headerMessage: '',
            };
        }

        const optionsWithSearch = OptionsListUtils.getSearchOptions(options, debouncedSearchValue, betas ?? []);

        const newOptions = OptionsListUtils.filterOptions(optionsWithSearch, debouncedSearchValue);

        const header = OptionsListUtils.getHeaderMessage(newOptions.recentReports.length > 0, false, debouncedSearchValue);
        return {
            recentReports: newOptions.recentReports,
            personalDetails: newOptions.personalDetails,
            userToInvite: optionsWithSearch.userToInvite,
            headerMessage: header,
        };
    }, [betas, debouncedSearchValue, options]);

We can also combine optionsWithSearch with newOptions to use one function

POC:

20240423_140801.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c732e2d542ec4ad2