[$250] [HOLD for payment 2024-07-10] Split bill - New group is created when splitting bill with the same users

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4496719
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Click on FAB > and create a split bill with two new users
2. Click on FAB > and create another split bill the same two users you have created with on step one

Expected Result:

New group shouldn't be created, and the split bill should be added to the existing group

Actual Result:

A second, new group is created

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6454834_1713538523579.Screen_Recording_2024-04-19_at_5.53.41_in_the_afternoon.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c9e84f7fad619cd5
• Upwork Job ID: 1811859168529416327
• Last Price Increase: 2024-07-12

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split bill - New group is created when splitting bill with the same users

What is the root cause of that problem?

We are not checking if the group chat exists or not before creating here

App/src/libs/actions/IOU.ts

Lines 3104 to 3119 in 9b2c518

	if (participants.length > 1) {
	const splitChatReport = ReportUtils.buildOptimisticChatReport(
	allParticipantsAccountIDs,
	'',
	CONST.REPORT.CHAT_TYPE.GROUP,
	undefined,
	undefined,
	undefined,
	undefined,
	undefined,
	undefined,
	CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
	);
	return {existingSplitChatReport: null, splitChatReport};
	}

What changes do you think we should make in order to solve the problem?

We should check if it already exists in onyx

   if (participants.length > 1) {
        const existing = ReportUtils.getChatByParticipants(allParticipantsAccountIDs, undefined, true) ?? null;
        const splitChatReport =
            !existing &&
            ReportUtils.buildOptimisticChatReport(
                allParticipantsAccountIDs,
                '',
                CONST.REPORT.CHAT_TYPE.GROUP,
                undefined,
                undefined,
                undefined,
                undefined,
                undefined,
                undefined,
                CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
            );
        return {existingSplitChatReport: existing, splitChatReport: existing ?? splitChatReport};
    }

currently getChatByParticipants doesn't include group chats so we should update it to take a parameter includeGroupChats and pass as true here

function getChatByParticipants(newParticipantList: number[], reports: OnyxCollection<Report> = allReports, includeGroupChats = false): OnyxEntry<Report> {
    const sortedNewParticipantList = newParticipantList.sort();
    return (
        Object.values(reports ?? {}).find((report) => {
            // If the report has been deleted, or there are no participants (like an empty #admins room) then skip it
            if (
                !report ||
                report.participantAccountIDs?.length === 0 ||
                isChatThread(report) ||
                isTaskReport(report) ||
                isMoneyRequestReport(report) ||
                isChatRoom(report) ||
                isPolicyExpenseChat(report) ||
                (isGroupChat(report) && !includeGroupChats)

What alternative solutions did you explore? (Optional)

Optonally we can update this line of code

App/src/libs/actions/IOU.ts

Lines 3088 to 3092 in 9b2c518

	// If we do not have one locally then we will search for a chat with the same participants (only for 1:1 chats).
	const shouldGetOrCreateOneOneDM = participants.length < 2;
	if (!existingSplitChatReport && shouldGetOrCreateOneOneDM) {
	existingSplitChatReport = ReportUtils.getChatByParticipants(participantAccountIDs);
	}

to

if (!existingSplitChatReport) {
        existingSplitChatReport = ReportUtils.getChatByParticipants(
            [...participantAccountIDs, ...(participantAccountIDs.length > 1 ? [currentUserAccountID] : [])],
            undefined,
            participantAccountIDs.length > 1,
        );
    }

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split bill - New group is created when splitting bill with the same users

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

Add below code above this line

const existingChatWithCurrentParticipants = ReportUtils.getChatByParticipants(participantAccountIDs)

if(!existingSplitChatReportID && !!existingChatWithCurrentParticipants){
    existingSplitChatReportID = existingChatWithCurrentParticipants.reportID
}

Update this line as follows getChatByParticipants(participants)?.reportID || ''

What alternative solutions did you explore? (Optional)

[FitseTLT]

Updated Only to add a refactored code for same solution

[joekaufmanexpensify]

I think this report is going to be obviated by a feature refactor we're working on. Discussing.

[joekaufmanexpensify]

Not overdue

[joekaufmanexpensify]

Bumped in slack

[joekaufmanexpensify]

Bumped 1:1

[joekaufmanexpensify]

Flagged again in Slack. This is definitely #vip-split related. But don't want to make external just yet since I feel like there is a solid chance we will close this.