"Set up" button flashes after QBO authentication finishes

[aldo-expensify]

Reported here: #39219 (comment)

Screen.Recording.2024-04-17.at.2.51.25.AM.mov

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

Break down in numbered steps

Expected Result:

Describe what you think should've happened

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01727b7169ced1ccbf
• Upwork Job ID: 1782479954581876736
• Last Price Increase: 2024-04-22

[aldo-expensify]

Not sure how to go about this yet.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[allgandalf]

@aldo-expensify , the condition && connectionSyncProgress.stageInProgress !== CONST.POLICY.CONNECTIONS.SYNC_STAGE_NAME.JOB_DONE; shouldn't be used here:

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Line 52 in 5a0e410

const isSyncInProgress = !!connectionSyncProgress?.stageInProgress && connectionSyncProgress.stageInProgress !== CONST.POLICY.CONNECTIONS.SYNC_STAGE_NAME.JOB_DONE;

When the stageInProgress is CONST.POLICY.CONNECTIONS.SYNC_STAGE_NAME.JOB_DONE at that time, isSyncInProgress is set to false , this triggers the Set up component to trigger:

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Lines 73 to 82 in 5a0e410

	if (!policyIsConnectedToAccountingSystem && !isSyncInProgress) {
	return [
	{
	icon: Expensicons.QBOSquare,
	iconType: CONST.ICON_TYPE_AVATAR,
	interactive: false,
	wrapperStyle: [styles.sectionMenuItemTopDescription],
	shouldShowRightComponent: true,
	title: translate('workspace.accounting.qbo'),
	rightComponent: <ConnectToQuickbooksOnlineButton policyID={policyID} />,

[abekkala]

@aldo-expensify, do you want this internal or external?

[aldo-expensify]

I'm planning on working on this myself when I get some time.

@aldo-expensify , the condition && connectionSyncProgress.stageInProgress !== CONST.POLICY.CONNECTIONS.SYNC_STAGE_NAME.JOB_DONE; shouldn't be used here:

Thanks @GandalfGwaihir , I know why this is happening, but I haven't thought yet how I'm going to fix it. The problem is that the stage goes to jobDone before receiving the policy.connections data, so for a brief moment we are neither syncing nor have connection data.

[melvin-bot]

@abekkala, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[abekkala]

not overdue - @aldo-expensify will be working on this, labeling internal