[HOLD for payment 2024-04-25] [$250] Tax - Not here page opens when clicking currency in tax amount in transaction thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.62-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #39562

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat that has tax enabled
3. Create a manual request with tax
4. Go to transaction thread
5. Click Tax amount
6. Click on the currency

Expected Result:

If the currency for tax amount is not supposed to be accessible in transaction thread, the currency should not be clickable (production behavior)

Actual Result:

The currency in tax amount in transaction thread is clickable, and it leads to not here page instead of currency list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445917_1712841997487.20240411_212019.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015297f4039458a835
• Upwork Job ID: 1778496247330332672
• Last Price Increase: 2024-04-11

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@NikkiWines FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The currency in tax amount in transaction thread is clickable, and it leads to not here page instead of currency list

What is the root cause of that problem?

We use the IOURequestTaxAmountPage for edit flow now but we always pass the action as create here

https://github.croom/Expensify/App/blob/8f90c2567f020ed924a96593244727aace9a7d72/src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx#L109

What changes do you think we should make in order to solve the problem?

We should use action in route prop here instead of always passing create

 Navigation.navigate(
    ROUTES.MONEY_REQUEST_STEP_CURRENCY.getRoute(action, iouType, transactionID, reportID, backTo ? 'confirm' : '', Navigation.getActiveRouteWithoutParams()),
);

https://github.croom/Expensify/App/blob/8f90c2567f020ed924a96593244727aace9a7d72/src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx#L109

What alternative solutions did you explore? (Optional)

isCurrencyPressable={!isEditing}

If we can't edit the currency of taxAmount, we should pass isCurrencyPressable as false into MoneyRequestAmountForm if we're editing the tax amount.

App/src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx

Line 160 in 8f90c25

<MoneyRequestAmountForm

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015297f4039458a835

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)