iOS - Login - Offline indicator briefly appears on the login page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Build 1.4.60-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4477138
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Open the app.
2. Kill the app and reopen it

Expected Result:

The offline indicator should only appear on the login page when the user is experiencing network issues.

Actual Result:

The offline indicator briefly appears on the login page, despite having a stable network connection.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6438461_1712263828226.Offline_indicator.mp4

bandicam.2024-04-24.21-36-02-682.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[puneetlath]

@tienifr do you think the offline PR you're working on will solve this?

[ahmedGaber93]

@puneetlath This is a known issue react-native-netinfo/react-native-netinfo#572.
We use isInternetReachable to determine offline here, but the listener will get isInternetReachable = null for the first two times then after milliseconds return isInternetReachable = true/false.
If we can accept a workaround, I can add a workaround proposal to ignore null on the first 2 time or the first x second

[tienifr]

@puneetlath Yeah, my PR will fix the issue

[puneetlath]

Great, thanks!