[Awaiting Payment 22nd May] [$250] [Track Tax] - Support for tax tracking when offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #33927

Action Performed:

Precondition:

• User is an employee of Collect workspace that has taxes
• One of the tax rates is 0%

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Create a manual request with tax
4. Go to transaction thread
5. Go offline
6. Click on Tax rate and change to a lower tax rate
7. Click Amount and change the amount
8. Cick Tax amount
9. Click Save without editing the amount

Expected Result:

In Step 6 and 7, when changing request amount and tax rate offline, the tax amount will change accordingly

Actual Result:

In Step 6 and 7, when changing request amount and tax rate offline, the tax amount does not update.
However, when saving invalid tax amount, the error message does show the updated maximum allowed tax amount

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6437972_1712235846086.bandicam_2024-04-04_21-00-05-673.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b5995687f97137eb
• Upwork Job ID: 1777600527434604544
• Last Price Increase: 2024-04-09

[melvin-bot]

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@johnmlee101 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[MonilBhavsar]

This is not a deploy blocker
The feature is being rolled out and we just discussed this yesterday and will be implementing soon
https://expensify.slack.com/archives/C03UK30EA1Z/p1712146178754839?thread_ts=1700633473.392829&cid=C03UK30EA1Z

[MonilBhavsar]

@johnmlee101 I can handle this issue if you are fine with it