[HOLD for payment 2024-04-15] Return the approverAccountID and reimburserAccountID to Onyx

[luacmartins]

Problem

Coming from #37391 (review), we key personalDetails by accountID, but policy.approver and poliyc.reimburserEmail sends the approver email data back to Onyx, which leads to an inefficient lookup for personal details.

Why is this important

Affects performance

Solution

Send the approverAccountID and reimburserAccountID to Onyx so we can use that to lookup personal details instead of the approver email. Once that's done, we should remove getPersonalDetailByEmail

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01781c07caff758274
• Upwork Job ID: 1775199977020665856
• Last Price Increase: 2024-04-02

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01781c07caff758274

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[Christinadobrzyn]

I got this payment GH but I think it's for this job?

Should we just pay @s77rt in here?

[s77rt]

Yes. We should close the other one