[$500] Share code - Tapping reply in thread share code URL directs to page loading infinitely

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open a report
3. Send a message
4. Long press the message and select reply in thread
5. Send a message
6. Tap header
7. Copy share code
8. Login app with different account
9. Open a report
10. Paste copied URL and send the message
11. Tap URL link

Expected Result:

Tapping reply in thread share code URL must not direct to page loading infinitely

Actual Result:

Tapping reply in thread share code URL directs to page loading infinitely

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435622_1712066286508.repl.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012acca0fb0a485001
• Upwork Job ID: 1775461423696654336
• Last Price Increase: 2024-04-03
• Automatic offers:
• hungvu193 | Reviewer | 0

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping reply in thread share code URL directs to page loading infinitely

What is the root cause of that problem?

We wrap the condition to show not found page with the check !shouldShowSkeleton so the not found page will not show if shouldShowSkeleton is true.

App/src/pages/home/ReportScreen.tsx

Line 363 in c550afd

!shouldShowSkeleton &&

When we open the report which we cannot access, OpenReport API only returns the errorFields so isCurrentReportLoadedFromOnyx is false that leads shouldShowSkeleton is always true and then infinite skeleton appears

App/src/pages/home/ReportScreen.tsx

Line 346 in c550afd

const isCurrentReportLoadedFromOnyx = useMemo((): boolean => {

What changes do you think we should make in order to solve the problem?

We should remove !shouldShowSkeleton from this check

App/src/pages/home/ReportScreen.tsx

Line 363 in c550afd

!shouldShowSkeleton &&

and to fix the issue not found page appears briefly after signing, we can replace reportActionIDFromRoute here to the current reportID param of the route

currentReportIDFormRoute = route.params?.reportID
(!! currentReportIDFormRoute && !ReportUtils.isValidReportIDFromPath(currentReportIDFormRoute))), 

App/src/pages/home/ReportScreen.tsx

Line 371 in c550afd

(!!reportIDFromRoute && !ReportUtils.isValidReportIDFromPath(reportIDFromRoute))),

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012acca0fb0a485001

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

It was originally fixed here, however it caused this DB, so it was revert here

Ideally, we should implement #38955 again with the suggestion fix in this discussion

cc @roryabraham @ishpaul777