[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] [TS Migration] Define a concise way to access or default to an inexistent record

[mountiny]

Follow up issue for TS migration project. Coming from this spreadsheet

Define a concise way to access or default to an inexistent record (0, -1, etc)

Any more details for this one cc @blazejkustra @fabioh8010

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0127e590dfa2accb42
• Upwork Job ID: 1780548153949810688
• Last Price Increase: 2024-04-24
• Automatic offers:
• jjcoffee | Reviewer | 0
• godofoutcasts94 | Contributor | 0

Issue Owner

Current Issue Owner: @johncschuster

[fabioh8010]

Problem

Currently we have been defaulting nullable entity IDs to either 0 or -1 when it doesn’t exist as we can see here and here (and many other files throughout the project). The lack of conciseness when defaulting such IDs leads to confusion between developers and increased chance of bugs.

Solution

Standartise the default values of all Onyx entity IDs. Personally I think we should default all nullable entity IDs to -1 as it is a negative ID and theoretically we would never have a negative one in the DB (@mountiny makes sense to you?):

1. For each Onyx type inside src/types/onyx/, look for properties that ends with ID?: ..., e.g. managerID?: number;, parentReportID?: string;, iouReportID?: string; inside Report.ts
2. For each property, look for its usage throughout the codebase.
3. If that property is being defaulted to either 0 or -1, change it to -1.
4. Change TS_STYLE.md to include this advice of using -1 to default these kind of ID properties.
5. Test everything extensively.

[mountiny]

@fabioh8010 this makes sense to me, but I think we need to bring this up to slack for broader agreement, can you post the proposal to open source channel before proceeding?

[fabioh8010]

@mountiny Sure, I can post! But could you make this issue External? It was marked as External initially.