[HOLD for payment 2024-04-05] Web - Expense report - Approve button not disabled if selected before enabling Self-approval

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-1
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37348
Issue reported by: Applause - Internal Team

Action Performed:

precondition: user created a collect policy in OD, added a bank account, and set Direct reimbursements

1. Log in to OD as the admin of the collect policy
2. Navigate to the collect policy settings > Members
3. Enable the Prevent self-approval toggle
4. Log in to ND as the admin
5. Open the workspace chat and create a manual request
6. Disable the Prevent self-approval in OD
7. Refresh the page or open the report and submit the report in ND
8. Select Approve from the drop-down but do not click on it
9. Enable the the Prevent self-approval toggle in OD

Expected Result:

The approve button is disabled both on the report preview and in the expense report

Actual Result:

The approve button is not disabled if it was selected before enabling Self-approval. Clicking on the Approve button results in skeleton loading

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6424411_1711211397899.Recording__345.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[luacmartins]

Seems to have come from #37348