Taxes - Error shows up when disabling tax rate

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

• User is admin of Collect workspace.
• Tax settings (Tax custom name, default taxes) are blank.

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > Collect workspace.
3. Go to Taxes.
4. Add a tax rate
5. Click on the tax rate.
6. Toggle off Enable rate.

Expected Result:

The rate is disabled without issue.

Actual Result:

Error shows up when disabling tax rate.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423409_1711127031057.20240323_010001.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave-control

[nexarvo]

Seems like backend does not allow disabling tax when there is no default tax.

This API is working fine when we have a default tax available.

[Gonals]

Taking a look at this

[Gonals]

I think this is fine. We should not be able to remove the tax if there is no default, and, in the current flow, we create a default when enabling taxes, so I think we are fine.