[$500] Bank account - Error "You must accept the terms" shows up when the terms are accepted

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > any workspace.
3. Go to Bank account.
4. Click Click Connect online with Plaid.
5. Proceed with the setup.
6. In the final step (terms and agreements), click Save & continue.
7. Click Save & continue again.
8. Close the RHP.
9. Click Bank account.

Expected Result:

At the final step, after checking all terms and agreement, user will be able to set up bank account successfully.

Actual Result:

At the final step, after checking all terms and agreement, clicking on Save & continue button shows the error "You must accept the terms".
In Step 11, after closing bank account setup and reopening bank account RHP, the bank account is added successfully.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6423753_1711142400869.20240323_051525.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0171463c8654b8a151
• Upwork Job ID: 1772699947694186497
• Last Price Increase: 2024-04-02
• Automatic offers:
• fedirjh | Contributor | 0

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@muttmuure I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #wave-control.

[izarutskaya]

Production

bandicam.2024-03-23.20-05-24-015.mp4

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error "You must accept the terms" shows up when the terms are accepted

What is the root cause of that problem?

We use nullish operator ?? here, this introduces a bug when the reimbursementAccount?.achData?.acceptTermsAndConditions value is null:

App/src/pages/ReimbursementAccount/CompleteVerification/substeps/ConfirmAgreements.tsx

Lines 74 to 78 in 2003844

	const defaultValues = {
	isAuthorizedToUseBankAccount: reimbursementAccount?.achData?.isAuthorizedToUseBankAccount ?? false,
	certifyTrueInformation: reimbursementAccount?.achData?.certifyTrueInformation ?? false,
	acceptTermsAndConditions: reimbursementAccount?.achData?.acceptTermsAndConditions ?? false,
	};

What changes do you think we should make in order to solve the problem?

Use || operator instead

What alternative solutions did you explore? (Optional)

N/A