[$500] Task - Chat is not scrolled to bottom when edit a task

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

**Version Number:**1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/runs/view/20318&group_by=cases:section_id&group_order=asc&group_id=291935
Email or phone of affected tester (no customers): shussain+web@applausemail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Open an existing chat
2. Click the '+' > Assign Task
3. Give the task as Title, Description and Assignee > Confirm Task
4. Click on the created task in the chat
5. Change the name > Save
6. Verify there's an audit trail of the change in the chat thread
7. Make more changes to the task (you can change the title, description, assignee) > click Save
8. Verify that eventually the chat isn't fully scrolled to the bottom of last message (or audit trail change)

Expected Result:

Chat should always scroll to the bottom of the last message ( you should see the last message after making a change)

Actual Result:

After making multiple edits to a task, the chat thread isn't scrolled to the bottom.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423531_1711133132795.2024-03-22_23-44-10.mp4

2024-03-26_12-57-52.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d64def74796adc96
• Upwork Job ID: 1772488534557900800
• Last Price Increase: 2024-03-26
• Automatic offers:
• fedirjh | Reviewer | 0
• gijoe0295 | Contributor | 0

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat is not scrolled to bottom when edit a task

What is the root cause of that problem?

Whenever there's any new report action in the report, we should call the notifyNewAction:

App/src/libs/actions/Report.ts

Line 342 in d482a25

function notifyNewAction(reportID: string, accountID?: number, reportActionID?: string) {

to trigger scrollToBottom:

App/src/pages/home/report/ReportActionsList.js

Line 298 in 82da6b5

InteractionManager.runAfterInteractions(() => reportScrollManager.scrollToBottom());

That's what we've been doing for IOU requests (for eg here). But for edit task flow (editTask), we did not call it.

What changes do you think we should make in order to solve the problem?

Call Report.notifyNewAction(report.reportID, currentUserAccountID) after editing the task in editTask.

We should also do it for whatever actions create new report action/message in the chat. For example: editTaskAssignee, reopenTask, completeTask.

What alternative solutions did you explore? (Optional)

NA

[bernhardoj]

Same issue as #38855

[gijoe0295]

That's not correct @bernhardoj. This is a new behavior not on production and has different RCA with #38855.

[Christinadobrzyn]

Hum, I'm not able to reproduce this, it looks like the chat is at the bottom and the cursor is in the chat field when making edits to an assigned task.

2024-03-25_11-36-13.mp4

Asking QA for some clarification on the expected result vs actual result - https://expensify.slack.com/archives/C9YU7BX5M/p1711337939301019

[gijoe0295]

@Christinadobrzyn you need to scroll the task report up then make changes there. They expect that when there're new changes in that task report, it should scroll to bottom (just like regular chat report).

[Christinadobrzyn]

Ah okay, I think I'm able to reproduce, I updated the OP so it's clearer how to reproduce. I think this can be external and part of vip-vsb