[HOLD for payment 2024-04-09] [$500] Workspace - The left side bar remains as chat when clicking on WS invitation link

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Actual Result:

1. Go to staging.new.expensify.com
2. Go to Profile > Workspaces
3. Create a new workspace
4. Click Share icon
5. Click Copy
6. Paste the link in chat and send it
7. Click on the link

Expected Result:

The left side bar will be menu

Actual Result:

The left side bar remains as chat when clicking on WS invitation link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423434_1711128140057.20240323_011952.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01959b571907654054
• Upwork Job ID: 1771275226175332352
• Last Price Increase: 2024-04-09
• Automatic offers:
• Ollyws | Reviewer | 0
• tienifr | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@iwiznia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[iwiznia]

The left side bar will be menu

I have no idea what this means, can someone clarify?

[ahmedGaber93]

@iwiznia
it means it should be profile menu not chat list menu

Expected Result:

Actual Result:

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - The left side bar remains as chat when clicking on WS invitation link

What is the root cause of that problem?

Here :

App/src/pages/workspace/WorkspaceJoinUserPage.tsx

Line 48 in 107b378

Navigation.goBack(undefined, false, true);

we are defining routes as Navigation.goBack(undefined, false, true); which is taking us back but with inconsistency as
Navigation.goBack method is used to return to the previous screen, passing undefined to not pop any screens from the stack, false to not animate the transition, and true to dismiss the keyboard if open but while doing all that it causes inconsistency and we have already defined navigateAfterJoinRequest which is taking care of it.

What changes do you think we should make in order to solve the problem?

So, we need to replace this -

App/src/pages/workspace/WorkspaceJoinUserPage.tsx

Line 48 in 107b378

Navigation.goBack(undefined, false, true);

with this - navigateAfterJoinRequest();

What alternative solutions did you explore? (Optional)

I think alternatively we can navigate the user to Workspace Initial Page :

Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID ?? ''));

Result

Screen.Recording.2024-03-23.at.1.30.08.AM.mp4

Updated Proposal with result

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01959b571907654054