[HOLD for payment 2024-04-15] [$500] Distance - Unable to save second distance edit offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to workspace chat.
3. Create a distance request with three waypoints.
4. Go to request details page.
5. Go offline.
6. Click Distance.
7. Drag and drop the waypoints and save it.
8. Repeat Step 6 and 7.

Expected Result:

User will be able to save the second distance edit.

Actual Result:

User is unable to save the second distance edit.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423379_1711125466153.20240323_001712.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b020e3127d156e8f
• Upwork Job ID: 1772031538674204672
• Last Price Increase: 2024-03-24
• Automatic offers:
• GandalfGwaihir | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is unable to save the second distance edit.

What is the root cause of that problem?

We prevent the user save the distance if the transaction is loading.

App/src/pages/iou/request/step/IOURequestStepDistance.js

Lines 190 to 192 in 7f5cf61

	if (duplicateWaypointsError || atLeastTwoDifferentWaypointsError || hasRouteError || isLoadingRoute || isLoading) {
	setShouldShowAtLeastTwoDifferentWaypointsError(true);
	return;

So in offline, after the first time we edit the distance, we can't edit this anymore.

What changes do you think we should make in order to solve the problem?

As the old edit distance flow, we should allow user saving the distance if we're offline event the transaction is loading

if (duplicateWaypointsError || atLeastTwoDifferentWaypointsError || hasRouteError || isLoadingRoute || (isLoading && !isOffline)) {
    setShouldShowAtLeastTwoDifferentWaypointsError(true);
    return;
}

App/src/pages/iou/request/step/IOURequestStepDistance.js

Lines 190 to 192 in 7f5cf61

	if (duplicateWaypointsError || atLeastTwoDifferentWaypointsError || hasRouteError || isLoadingRoute || isLoading) {
	setShouldShowAtLeastTwoDifferentWaypointsError(true);
	return;

What alternative solutions did you explore? (Optional)

NA

[ZhenjaHorbach]

Looks like a regression from this PR
#35302