[HOLD for payment 2024-04-15] [$500] Self - DM - App returns to previous conversation instead of self-DM after leaving self-DM thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.55-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/S
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to 1:1 DM
3. Send a message, reply in thread and leave thread
4. Note that user is redirected to 1:1 DM in Step 2
5. Click the Search icon in the LGN > type 'you' > start a self DM
6. Send a message, reply in thread and leave thread

Expected Result:

After leaving thread, app will return to self-DM

Actual Result:

After leaving thread, app returns to a previous conversation before self-DM

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6420704_1710951422604.20240321_001108.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016b6d3e4e9cf9c054
• Upwork Job ID: 1770633111502032896
• Last Price Increase: 2024-03-21
• Automatic offers:
• abzokhattab | Contributor | 0

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to previous conversation instead of self-DM after leaving self-DM thread

What is the root cause of that problem?

we dont consider the self dm when calculating the lastAccessedReportID here which was added in this PR:

App/src/libs/actions/Report.ts

Lines 2363 to 2379 in 26ab4aa

	// We want to filter out the current report, hidden reports and empty chats
	const filteredReportsByLastRead = sortedReportsByLastRead.filter(
	(sortedReport) =>
	sortedReport?.reportID !== reportID &&
	sortedReport?.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN &&
	ReportUtils.shouldReportBeInOptionList({
	report: sortedReport,
	currentReportId: '',
	isInGSDMode: false,
	betas: [],
	policies: {},
	excludeEmptyChats: true,
	doesReportHaveViolations: false,
	}),
	);
	const lastAccessedReportID = filteredReportsByLastRead.at(-1)?.reportID;

What changes do you think we should make in order to solve the problem?

we need to add includeSelfDM: true, to the shouldReportBeInOptionList function input above

POC

Screen.Recording.2024-03-20.at.7.23.21.PM.mov

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Self - DM - App returns to previous conversation instead of self-DM after leaving self-DM thread

What is the root cause of that problem?

• In here, we allow user to leave in case of selfDM 's thread.
• And when leaving room, we do not include the selfDM in here, that leads to the bug.

What changes do you think we should make in order to solve the problem?

• We should not allow user to leave the selftDM 's thread because the self-DM is the spot for private notes. We can do it by update this to:

    const outerMostReportID = last(getAllAncestorReportActionIDs(report).reportIDs)
    const isSelfDMThread = ReportUtils.isSelfDM(getReport(outerMostReportID))
    const canJoinOrLeave = !isSelfDMThread && !isSelfDM && (isChatThread || isUserCreatedPolicyRoom || canLeaveRoom);

What alternative solutions did you explore? (Optional)

• Additonally, because the self-DM is the spot for private notes, so we should not display the selfDM 's threads in LHN. We can do it by adding the below logic to this one:

    const outerMostReportID = last(getAllAncestorReportActionIDs(report).reportIDs);
    const isSelfDMThread = isSelfDM(getReport(outerMostReportID));
    if (isSelfDMThread) {
        return false;
    }

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to previous conversation instead of self-DM after leaving self-DM thread

What is the root cause of that problem?

We have not set includeSelfDM to true in shouldReportBeInOptionList:

App/src/libs/actions/Report.ts

Lines 2348 to 2357 in 399077f

	ReportUtils.shouldReportBeInOptionList({
	report: sortedReport,
	currentReportId: '',
	isInGSDMode: false,
	betas: [],
	policies: {},
	excludeEmptyChats: true,
	doesReportHaveViolations: false,
	}),
	);

What changes do you think we should make in order to solve the problem?

When saw other pages which use shouldReportBeInOptionList we pass the value of includeSelfDM as true everywhere.

App/src/libs/SidebarUtils.ts

Lines 85 to 93 in 399077f

	return ReportUtils.shouldReportBeInOptionList({
	report,
	currentReportId: currentReportId ?? '',
	isInGSDMode,
	betas,
	policies,
	excludeEmptyChats: true,
	doesReportHaveViolations,
	includeSelfDM: true,

App/src/libs/OptionsListUtils.ts

Lines 1451 to 1459 in 399077f

	return ReportUtils.shouldReportBeInOptionList({
	report,
	currentReportId: Navigation.getTopmostReportId() ?? '',
	betas,
	policies,
	doesReportHaveViolations,
	isInGSDMode: false,
	excludeEmptyChats: false,
	includeSelfDM,

App/src/libs/OptionsListUtils.ts

Lines 1451 to 1459 in 399077f

	return ReportUtils.shouldReportBeInOptionList({
	report,
	currentReportId: Navigation.getTopmostReportId() ?? '',
	betas,
	policies,
	doesReportHaveViolations,
	isInGSDMode: false,
	excludeEmptyChats: false,
	includeSelfDM,

So to avoid redundancy of code i propose that we update the shouldReportBeInOptionList function itself to set the default value of includeSelfDM to true, currently it is set to false:

App/src/libs/ReportUtils.ts

Lines 4176 to 4185 in 399077f

	function shouldReportBeInOptionList({
	report,
	currentReportId,
	isInGSDMode,
	betas,
	policies,
	excludeEmptyChats,
	doesReportHaveViolations,
	includeSelfDM = false,
	}: {

Then we remove the redundant part of the code in every component

What alternative solutions did you explore? (Optional)

N/A

[Christinadobrzyn]

I can recreate this based on the steps in the OP - I think this can be external and part of vip-vsb

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016b6d3e4e9cf9c054