Personal details - "common.zipCodeExampleFormat" appears under Zip / Postcode field

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.55-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Address is not filled in Private section.

1. Go to staging.new.expensify.com.
2. Go to Profile
3. Click Address.

Expected Result:

There will be no strings under Zip / Postcode field since the address is not filled.

Actual Result:

"common.zipCodeExampleFormat" appears under Zip / Postcode field.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@sakluger I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.:

Personal details - "common.zipCodeExampleFormat" appears under Zip / Postcode field.

What is the root cause of that problem?

No fallback is provided when country is not there. So zipSampleFormat becomes empty

App/src/components/AddressForm.tsx

Lines 78 to 80 in f4d3c18

	const zipSampleFormat = (country && (CONST.COUNTRY_ZIP_REGEX_DATA[country] as CountryZipRegex)?.samples) ?? '';
	const zipFormat: MaybePhraseKey = ['common.zipCodeExampleFormat', {zipSampleFormat}];

What changes do you think we should make in order to solve the problem?

Add CONST.COUNTRY_ZIP_REGEX_DATA.US.samples as fallback for zipSampleFormat.

const zipSampleFormat = country ? (CONST.COUNTRY_ZIP_REGEX_DATA[country] as CountryZipRegex)?.samples : CONST.COUNTRY_ZIP_REGEX_DATA.US.samples;

Result