[Simplified Collect][Taxes] It crashes if you try to add a custom name without having any taxes

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.54.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #38373

Action Performed:

Precondition: With a new expensifail account, create a Collect workspace with workspace chat enabled

1. Navigate to Workspace settings - Taxes - Settings - Custom tax name
2. Type in any name
3. Click on the "Save" button

Expected Result:

It shouldn't crash

Actual Result:

It crashes if you try to add a custom name without having any taxes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418254_1710788901865.bandicam_2024-03-18_20-03-32-375.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@jasperhuangg FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[mountiny]

@luacmartins I beelive this should be fixed with adding the default taxes optimistically

[mountiny]

I assume we have to fix the crash though

[luacmartins]

I don't think this is a blocker since users don't have access to these pages yet. cc @kosmydel @filip-solecki