Distance offline - Can't delete red dot Error on the request preview in the expense report

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4424763&group_by=cases:section_id&group_order=asc&group_id=295814
Email or phone of affected tester (no customers): applausetester+requestor.yuriy.14.mar@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Turn off the network
2. Crete distance request with way points kind of “hdhdfjfnfb”
3. Turn on the network
4. Wait for Reddot error
5. Open request details (now you have two reddot errors in the LHN)
6. Try to dismiss reports with reddot errors

Expected Result:

The user should be able to dismiss red dot errors because of invalid Distance expense

Actual Result:

There is no button to dismiss red dot error on the request preview in the expense report.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-03-15.at.14.43.12.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

@alexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

[trjExpensify]

It would be great if the steps were more specific about which chats etc have the red brick road and don't clear properly. Here's my understanding of the issue being reported:

Action steps

1. Go offline
2. Crete a distance request with invalid waypoints (e.g "hdhdfjfnfb”)
3. Go back online
4. Observe the "unexpected error" message is added as the distance requests fails to create
5. Observe the red brick road (RBR) red dots added to both the workspace chat row and the expense report row in the LHN
6. Dismiss the error message ("X") beneath the report preview component in the workspace chat
7. Observe the expense report preview component disappears from the workspace chat and the RBR red dot is cleared from the workspace chat row in the LHN
8. Observe the expense report row in the LHN remains and with the RBR red dot
9. Click into the expense report
10. Click on the distance request preview
11. Observe the 404 "Hmm.. it's not there" full page blocking error

For the expected results. I think this is less about the RBR being dismissable on the expense report, but rather, why does it remain accessible at all? Recall you dismissed the error message and the report preview component disappeared, so it should have been deleted and thus removed from the LHN completely.

Expected Results
When the error message is dismissed, delete the distance request and expense report. (Of course, don't do that if there are other expenses on the report already!)

Let me know if I'm missing something! CC: @paultsimura @neil-marcellini @hayata-suenaga

9e4inAQbsN.mp4

[paultsimura]

For Expense requests, when the CreateDistanceRequest response comes, the Money Request and the Expense Report are removed, and only the Expense Report preview stays with the RBR. Am I missing something?

Screen.Recording.2024-03-15.at.15.03.4215.04.mp4

[trjExpensify]

Ah, interesting.. why isn't the expense report showing up in the LHN when you give it a go? See mine from above:

1. It fails after coming back online
2. The expense report row appears in the LHN with a red dot (in addition to the workspace chat row).
3. Dismissing the error on the expense report preview component inside the workspace chat doesn't remove the expense report row from the LHN

This is reproducible only for 1:1 Distance Requests (which is still under Beta).

My repro was distance requests to a workspace, so not 100% sure on that.

[paultsimura]

My repro was distance requests to a workspace, so not 100% sure on that.

That's weird indeed. Removed it from my comment to avoid misleading 🤔

[trjExpensify]

I thought it might be a violations beta or something, but I don't have that beta enabled on my @trj.chat domain.

[paultsimura]

why isn't the expense report showing up in the LHN when you give it a go?

It shows up, it just didn't fit the screen on the recording. I even tried pinning the optimistically created Expense report – it disappears after coming back online.