[HOLD for payment 2024-04-05] [$500] when sending money offline, the optimistically created IOU Report shows the top skeleton.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.50-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @paultsimura
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710189233319759

Action Performed:

1. Open any chat
2. Go offline
3. Click "+" -> "Send money"
4. Complete the flow
5. Open the newly created IOU Report

Expected Result:

The IOU Report header with total is shown instead of the skeleton

Actual Result:

There is no IOU Report header with total , but a skeleton is displayed instead

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2845.mp4

Screen.Recording.2024-03-11.at.21.29.08-compressed.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016a019c25a41f6d94
• Upwork Job ID: 1767621253695864832
• Last Price Increase: 2024-03-12

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[paultsimura]

Per our conversation with @cead22, please assign me as C+ here once it goes External. Thanks

[ahmedGaber93]

@paultsimura
i can't understand the Actual Result There is no IOU Report header with total, i already see IOU Report header with total in the video. what's wrong.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no IOU Report header with total , but a skeleton is displayed instead

What is the root cause of that problem?

We create wrong optimistic data in getSendMoneyParams function, we add the optimistic created action of IOU report to chat report actions, leading the created actions of IOU report doesn't exist and then skeleton view is displayed.

App/src/libs/actions/IOU.ts

Line 3427 in eb6213f

optimisticChatReportActionsData.value[optimisticCreatedActionForIOUReport.reportActionID] = optimisticCreatedActionForIOUReport;

What changes do you think we should make in order to solve the problem?

We should add the optimisticCreatedActionForIOUReport to optimisticIOUReportActionsData here instead of adding it to optimistic report action of the chat report

const optimisticIOUReportActionsData: OnyxUpdate = {
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${optimisticIOUReport.reportID}`,
    value: {
        [optimisticIOUReportAction.reportActionID]: {
            ...(optimisticIOUReportAction as OnyxTypes.ReportAction),
            pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
        },
        [optimisticCreatedActionForIOUReport.reportActionID]: {
            ...(optimisticCreatedActionForIOUReport as OnyxTypes.ReportAction)
        }
    },
};

App/src/libs/actions/IOU.ts

Line 3427 in eb6213f

optimisticChatReportActionsData.value[optimisticCreatedActionForIOUReport.reportActionID] = optimisticCreatedActionForIOUReport;

OPTIONAL: if the chat report is a new chat, we also should generate a created action for chat report as well.

What alternative solutions did you explore? (Optional)

NA

[paultsimura]

@paultsimura i can't understand the Actual Result There is no IOU Report header with total, i already see IOU Report header with total in the video. what's wrong.

It's about this one (you can see it appears at the end of the second video):

[cead22]

Assigned @paultsimura as C+ for this since @paultsimura has context on this issue

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016a019c25a41f6d94

[melvin-bot]

Current assignee @paultsimura is eligible for the External assigner, not assigning anyone new.