[HOLD for payment 2024-04-09] [$500] Profile page opens with a lag when clicking from a chat

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.49-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709868083089229

Action Performed:

1. Login with high traffic account
2. Go to any report that has messages.
3. Click on user avatar

Expected Result:

Profile page should appear smoothly

Actual Result:

It's a bit laggy when Profile page appears.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-03-08.at.10.21.31.mov

Recording.2831.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0127b4383974c1d34e
• Upwork Job ID: 1768699308285607936
• Last Price Increase: 2024-03-15
• Automatic offers:
• c3024 | Reviewer | 0
• tienifr | Contributor | 0

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[hungvu193]

offending PR as I mentioned earlier in slack: #37223

[jakub-trzebiatowski]

I'm not sure about classifying this as regression... We didn't notice any performance issues when testing #37223. Of course, this can depend on many factors, including the hardware the web app is being tested on.

We haven't added any new logic. Before our PR, the API was still called under some conditions. We just made the conditions less strict. This performance glitch must have been present before; it's just more easily observable now.

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile page lagging when opened.

What is the root cause of that problem?

After the updates from #37223

Every component using withOnyx to key: ONYXKEYS.PERSONAL_DETAILS_LIST will be rendered once we open the profile page and this cause lots of browser memory usage in the background due to lost of images called.

What changes do you think we should make in order to solve the problem?

On profile page, we need to check if we already have the profile details available, if so, we don't have to call the API.

const profileDetailsAvailable = details.avatar && details.avatarThumbnail && details.displayName && details.login && details.timezone;

useEffect(() => {
        if (ValidationUtils.isValidAccountRoute(accountID) && !profileDetailsAvailable) {
            PersonalDetails.openPublicProfilePage(accountID);
        }
    }, [accountID, profileDetailsAvailable]);

What alternative solutions did you explore? (Optional)

Display a loading indicator as in the avatar modal. If we always need to fetch the API what ever the available details, we can display a loading indicator to give the API the time to turn back the images and to the browser to load it.

[trjExpensify]

We haven't added any new logic. Before our PR, the API was still called under some conditions. We just made the conditions less strict. This performance glitch must have been present before; it's just more easily observable now.

@puneetlath @stitesExpensify as you guys were involved in #36610, do you agree with this assessment or do you think this is a regression from the PR?

[stitesExpensify]

I think that both things are true. The performance issue did exist under some conditions, but that PR has caused it to happen under all conditions. To me that is a regression since this was not happening all of the time before and is happening now.

[jakub-trzebiatowski]

@kmbcook Could you take a look at this?

[kmbcook]

#36610 is unusual in that it requires the API to be called every time an avatar is clicked. Most issues are about improving some aspect of user experience, such as this one. 36610 is different in that it is about implementing a specified method of operation (not about improving a specified aspect of user experience).

It is true that always calling the API does solve some problems, and that there may be other ways to solve those problems. It may be appropriate to create additional issues specific each of those problems and invite proposals.

This issue is not a regression, rather it is a consequence of implementing the method of operation required by the other issue.

[puneetlath]

Question: if you already have the personal details locally for userA. And then you open the profile page of userA which calls the API and returns/merges the same personal details that you already have. Why does anything re-render? Nothing in Onyx or any of the props has actually changed right?