Skip to content

[HOLD for payment 2024-05-08] [Simplified Collect][CLEAN UP][LOW] Standardize on Workspace wrapper #37898

Description

@luacmartins

Problem

Coming from here, we have a few wrappers we use in Workspace pages, i.e. WorkspacePageWithSections, AdminPolicyAccessOrNotFoundWrapper and PaidPolicyAccessOrNotFoundWrapper. We should standardize on using a single one for all our pages.

Those wrappers also break the not-found views.

Going to e.g. https://staging.new.expensify.com/workspace/dssaddssdaads/categories` we see duplicated not found (that's what is the scope of the other issue) and after pressing the back button we see another ones...

Why is this important

DRYs code and makes it more maintainable

Solution

Investigate how to combine them and update all usages.

cc @kosmydel

Issue OwnerCurrent Issue Owner: @JmillsExpensify

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type
No fields configured for issues without a type.

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions