Chat - Video is restarted when opened on attachment window

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4395697
Email or phone of affected tester (no customers): vdargentotest+web030624@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Pre-requisite: the user must be logged in

1. Go to any chat
2. Send a video
3. Play the video
4. Verify the video is being played on the preview
5. Click on the expand button to open it on attachment window
6. Verify the video is restarted
7. Go back to the chat
8. Verify the video is not restarted on the preview

Expected Result:

The video should continue to play at the same point when expanded

Actual Result:

The video is restarted when expanded

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6404725_1709767873848.bandicam_2024-03-06_19-29-34-035.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[lanitochka17]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Video is restarted when opened on attachment window.

What is the root cause of that problem?

Current position is not being passed while navigating to the attachment.
Below code is from VideoRenderer.tsx.

const route = ROUTES.REPORT_ATTACHMENTS.getRoute(report?.reportID ?? '', sourceURL);
Navigation.navigate(route);

What changes do you think we should make in order to solve the problem?

In the route, pass a new parameter called lastPosition or startPosition. The video's positionMillis can be set as lastPosition when the expand button is clicked.

getRoute will be updated as:

getRoute: (reportID: string, source: string) => `r/${reportID}/attachment?source=${encodeURI(source)}&lastPosition=${lastPosition}` as const,

We can also use the name startPosition instead of lastPosition.

Then, we can use playFromPositionAsync in full screen mode and pass the lastPosition.

[alexpensify]

I'll test early next week and we can figure out the next steps. Thanks!

[melvin-bot]

@alexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alexpensify]

No update yet, I need to test.

[alexpensify]

@Expensify/design - I was able to replicate this experience but is this something we want to address? I checked other chat tools and they do continue playing when you move the chat between sizes. Thanks for the feedback!

[dannymcclain]

Personally I feel like it's worth addressing. I would find this pretty annoying. I'll let others weigh in too to see if everyone thinks it's annoying enough to prioritize though.

[shawnborton]

Yeah, I totally agree here.