[$500] BA - Error is not cleared after coming back to Connect manually empty form.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.47-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+vd_mweb030424@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

Pre-requisite: the user must be logged in and have created a Workspace.

1. Go to Workspace > Bank account.
2. Tap on Connect manually.
3. Enter "011401533" as the Routing number.
4. Enter "0000" as the Account number.
5. Tap on Next.
6. Confirm on the double check page.
7. Verify you are taken back to the form and an error is displayed.
8. Tap on "fix the errors".
9. Verify nothing happens.
10. Tap on the back arrow.
11. Tap on Connect manually.
12. Verify that the error is still displayed.

Expected Result:

When the error appears, tapping on "fix the errors" should focus where the error is. After coming back to the empty form, the error should not be displayed.

Actual Result:

When the error appears, tapping on "fix the errors" does nothing. After coming back to the empty form, the error is still displayed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6402475_1709626017108.Fekl5139_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011eb90ac2e3759c98
• Upwork Job ID: 1767861127265402880
• Last Price Increase: 2024-03-13
• Automatic offers:
• s77rt | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

@dylanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message persist when navigating back and to the screen again

What is the root cause of that problem?

The error message on Manual is from a parent component ReimbursementAccountPage on an Onyx data.

Going back and to the screen again, does not erase or nullish the error value.

What changes do you think we should make in order to solve the problem?

When we trigger the goBack action from the Manual add your bank account screen to the previous screen, we need to update the Onyx value of the error message.

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 377 to 379 in e3b10f7

	} else {
	Navigation.goBack();
	}

What alternative solutions did you explore? (Optional)

[dylanexpensify]

Apologies, I've been OOO sick, but getting to this today!

[dylanexpensify]

Apologies on delay here, team! Was sick all last week. Looking into this now!

[dylanexpensify]

Confirming here on placement!

[Swor71]

hey, I'm Marcin from Callstack - expert contributor group - I'd like to help with this issue