[HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Split scan - Split button in split menu is gray instead of green

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.47-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat > + > Split bill.
3. Go to Scan.
4. Create a scan split request.
5. Click on the split preview.

Expected Result:

The split button will be green.

Actual Result:

The split button is gray.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6402237_1709602730996.bandicam_2024-03-05_06-23-19-887__1_.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think that this bug might be related to #vip-split-p2p-chat-groups
cc @arielgreen

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The split button is gray.

What is the root cause of that problem?

From this PR #37199, the default value success of success is false

App/src/components/ButtonWithDropdownMenu/index.tsx

Line 17 in a79c119

success = false,

and we don't pass success as true into ButtonWithDropdownMenu so the split button displays as the default button

App/src/components/MoneyRequestConfirmationList.js

Line 552 in a79c119

<ButtonWithDropdownMenu

What changes do you think we should make in order to solve the problem?

Pass success as true into ButtonWithDropdownMenu

App/src/components/MoneyRequestConfirmationList.js

Line 552 in a79c119

<ButtonWithDropdownMenu

What alternative solutions did you explore? (Optional)

Change the default value of success prop of ButtonWithDropdownMenu to true