[$500] [HOLD for payment 2024-03-19] Do not show "member not found" when loading member list

[luacmartins]

Coming from this comment, we should not show "member not found" while loading the member list

cc @burczu

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d5126ce1290525b2
• Upwork Job ID: 1770042366576177152
• Last Price Increase: 2024-03-19

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[aimane-chnaif]

Happy to review this as C+

[rayane-d]

Proposal

Please re-state the problem that we are trying to solve in this issue.

we are showing "member not found" while loading the member list.

What is the root cause of that problem?

Here:

App/src/pages/workspace/WorkspaceMembersPage.tsx

Lines 352 to 357 in 85dc2f6

	const getHeaderMessage = () => {
	if (isOfflineAndNoMemberDataAvailable) {
	return translate('workspace.common.mustBeOnlineToViewMembers');
	}
	return !data.length ? translate('workspace.common.memberNotFound') : '';
	};

when data is empty we show the "member not found" message, but we should not show it when members are still loading

What changes do you think we should make in order to solve the problem?

we should use the same condition used here:

App/src/pages/workspace/WorkspaceMembersPage.tsx

Line 461 in 85dc2f6

showLoadingPlaceholder={!isOfflineAndNoMemberDataAvailable && (!OptionsListUtils.isPersonalDetailsReady(personalDetails) || isEmptyObject(policyMembers))}

in getHeaderMessage function, like this:

    const getHeaderMessage = () => {
        if (isOfflineAndNoMemberDataAvailable) {
            return translate('workspace.common.mustBeOnlineToViewMembers');
        }
        return (!data.length && (!OptionsListUtils.isPersonalDetailsReady(personalDetails) || isEmptyObject(policyMembers))) ? translate('workspace.common.memberNotFound') : '';
    };

[aimane-chnaif]

I am not sure this will be be external.
@burczu may take this.

[burczu]

Hey I'm Bartek from Callstack - could you please assign this issue to me?