[HOLD for payment 2024-04-03] [$500] Scan- After uploading a corrupted file, user needs to dismiss error from 2 reports

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.45-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1.Log in in the app
2.Start the Request money ; "Scan" receipt flow
3.Upload a corrupted file
4. After the upload fails the user sees a red error message explaining that the file was not uploaded
5.Click on the X to dismiss the error

Expected Result:

The expense is deleted and the red error message disappears

Actual Result:

The user needs to dismiss the error separately from the report chat in LHN and the request chat in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6397079_1709215239565.failedittwice.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e40cdcd3593e0c5a
• Upwork Job ID: 1763390673983709184
• Last Price Increase: 2024-03-08
• Automatic offers:
• Pujan92 | Reviewer | 0
• rayane-djouah | Contributor | 0

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[m-natarajan]

We think that this bug might be related to #vip-billpay
cc @davidcardoza

[m-natarajan]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e40cdcd3593e0c5a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[rayane-d]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scan- After uploading a corrupted file, user needs to dismiss error from 2 reports.

What is the root cause of that problem?

When uploading a corrupted file, there'll be 2 different errors created on the IOU report preview here and the IOU report action here.
and when dismissing an error on one of them we are clearing only the errors of the report action that we clicked dismiss errors on, here.
when we dismiss the error on the iou action we execute this code that clear errors on the report preview action.
when we dismiss the error on the report preview we execute this code that delete the iou action here.

What changes do you think we should make in order to solve the problem?

1. to dismiss the error on the report preview action when we dismiss the error on the iou action, we should add this code here to dismiss the error on the report preview action:

    if (reportAction.errors) {
        Object.entries(reportAction.errors).forEach(([key, errorValue]) => {
            // dismiss receipt error in iou action in child iou report 
            if (errorValue.error === CONST.IOU.RECEIPT_ERROR) {
                if (errorValue.iouActionID) {
                    Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportAction.childReportID}`, {
                        [errorValue.iouActionID]: {
                            errors: null,
                        },
                    });
                }
            }
        });
    }

2. to dismiss the error on the the iou action when we dismiss the error on report preview action:

• we should add an optional iouActionID attribute in the error when building the error here.
  like this:

function getReceiptError(receipt?: Receipt, filename?: string, isScanRequest = true, /*add this arg: */ iouActionID?: string): Errors | ErrorFields {
    return isEmptyObject(receipt) || !isScanRequest
        ? ErrorUtils.getMicroSecondOnyxError('iou.error.genericCreateFailureMessage')
        : ErrorUtils.getMicroSecondOnyxErrorObject({error: CONST.IOU.RECEIPT_ERROR, source: receipt.source?.toString() ?? '', filename: filename ?? '', /*add this attribute: */ iouActionID: iouActionID ?? ''});
}

• and we should pass the iouActionID to the getReceiptError when creating the error on the report preview here

errors: getReceiptError(transaction?.receipt, transaction.filename || transaction.receipt?.filename, isScanRequest, iouAction.reportActionID),

• and add a logic to clear the error on the report preview when clearing the iou action error here

// Dismiss receipt error in report preview action
if (reportAction.errors) {
    Object.entries(reportAction.errors).forEach(([key, errorValue]) => {
        if (errorValue.error === CONST.IOU.RECEIPT_ERROR) {
            if (report.parentReportActionID) {
                Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`, {
                    [report.parentReportActionID]: {
                        errors: null,
                    },
                });
            }
        }
    });
}

to do this we should pass report instead of reportId to clearReportActionErrors function.

Compare changes

Branch link for testing