[HOLD for payment 2024-04-09] [$500] [Held requests] show status on distance requests

[robertjchen]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Coming from the discussion here: #37121 (comment)

Update display of status on distance requests to show state (Approved/Pending/Canceled/Hold) like we do for Cash expenses.

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1710439388757009

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Create a distance request
4. Go to request details page
5. Click 3-dot menu > Hold request
6. Add a reason and save it

Expected Result:

Distance expense request should show Hold

Actual Result:

Distance expense request does not show any status

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e3e32c45e45f949f
• Upwork Job ID: 1769963579385311232
• Last Price Increase: 2024-03-19
• Automatic offers:
• situchan | Reviewer | 0
• ShridharGoel | Contributor | 0

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[rayane-d]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold status is not displayed on distance and receipt requests previews.

What is the root cause of that problem?

Here:

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Lines 168 to 170 in 0bbfcd6

	} else if (isOnHold) {
	message += ` • ${translate('iou.hold')}`;
	}

we are appending the • Hold status only for cash requests.
and here:

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Lines 134 to 140 in 0bbfcd6

	if (isDistanceRequest) {
	return translate('common.distance');
	}
	if (isScanning) {
	return translate('common.receipt');
	}

we are not appending the • Hold status for distance and receipt requests.

What changes do you think we should make in order to solve the problem?

we need to add here this logic:

if (isDistanceRequest) {
    let message = translate('common.distance');
    if (isOnHold) {
        message += ` • ${translate('iou.hold')}`;
    }
    return message;
}

if (isScanning) {
    let message = translate('common.receipt');
    if (isOnHold) {
        message += ` • ${translate('iou.hold')}`;
    }
    return message;
}

only cash, receipt, and distance requests can be hold, we don't need to add this logic to split and card transactions.

[melvin-bot]

@robertjchen, @stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@robertjchen, @stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

[stephanieelliott]

Hey @robertjchen just want to check where we landed with this one from the original discussion in #37121 (comment) so we can figure out the Actual Result vs Intended Result

@robertjchen for now, • xxx is showing only after Cash (manual request)
i.e. not showing for distance requests. Is this expected (or at least out of scope)?

@situchan great catch! Let's pull this discussion to Slack to determine what's the best course of action. I think this change can go out in the interim however 👍

Was this ever pulled into Slack (I can't find anything)? Or was there general agreement that distance expenses should show the status (Hold, Approved, Pending, Canceled etc) on distance expenses?

[situchan]

oh it seems no discussion happened. Please assign me here.
I will raise discussion on slack.

[rayane-d]

Currently (in here) we only show the "Hold, Approved, Pending, Canceled" status and violations in cash requests previews.
for card transactions, we only shows "Pending" status.
for distance, receipt, and split requests, we are not including the status in the preview header text